GIFImageReader.h / .cpp should get the Blink renaming |
||||
Issue descriptionBlink recently went through a style change. But GIFImageReader.h / .cpp was uneffected by the renaming tool. This happened because GIFImageReader was not inside the blink namespace. After moving GIFImageReader into the blink namespace, we should apply the new Blink style to the GIFImageReader.
,
May 2 2017
,
May 2 2017
,
May 3 2017
(Adding my comments on issue 717697 , since I think this is more relevant here.) In light of in-progress https://codereview.chromium.org/2565323003/, which deletes GIFImageReader, is it worth modifying this file? (Leaving the style alone will also help make sure that we apply any real changes that have been made to that file since I forked it into Skia.) And cblume's response: For GIFImageReader, it is probably a good idea to leave it alone.
,
May 30 2017
GIFImageReader was moved into blink namespace and converted here: https://chromium-review.googlesource.com/c/505284 |
||||
►
Sign in to add a comment |
||||
Comment 1 by cblume@chromium.org
, May 2 2017