Image decoder code should be entirely inside Blink namespace |
|||||
Issue descriptionWith the recent Blink renaming, GIFImageReader.h / .cpp did not get updates. When investigating, we found it is because GIFImageReader is not inside the blink namespace. The tool only updated contents inside the blink namespace. In addition to this, free functions that are in an anonymous namespace also did not get updated. The anonymous namespace should be nested inside the blink namespace.
,
May 2 2017
,
May 2 2017
,
May 2 2017
In light of in-progress https://codereview.chromium.org/2565323003/, which deletes GIFImageReader, is it worth modifying this file?
,
May 2 2017
(Leaving the style alone will also help make sure that we apply any real changes that have been made to that file since I forked it into Skia.)
,
May 2 2017
For GIFImageReader, it is probably a good idea to leave it alone. Style changes aren't fixing immediate problems. It is only a problem if things diverge and the code becomes inconsistent and difficult to read, which should no longer be a concern for gifs. However, other free functions that should be moved into the blink namespace. An example is: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp?q=PNGImageReader+package:%5Echromium$&dr=CSs&l=54 There is a bug specifically for GIFImageReader.h / .cpp: https://crbug.com/717698 And there is a bug specifically for the free functions: https://crbug.com/717700
,
Sep 4
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cblume@chromium.org
, May 2 2017