New issue
Advanced search Search tips

Issue 717695 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Potential leak with status_tray_state_changer_win.cc

Reported by mbh...@gmail.com, May 2 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
Reproduced using Windows 10 and a debugger:

1. In chromium, ITrayNotifyWin8::UnregisterCallback has a prototype accepting unsigned long *

2. Calling this function as provided appears to fail, leaving the previously-set INotificationCB with refcount=3 (i.e. it leaks)

3. If the API is called with "unsigned long" (passing the handle directly, rather than the pointer), the INotificationCB is properly released.

What is the expected behavior?
Unregister would deallocate all resources

What went wrong?
API prototype for "Unregister" should take an unsigned long and not a pointer.

Have not regressed on Windows 8.

Did this work before? No 

Chrome version: 57.0.2987.133  Channel: n/a
OS Version: 10.0
Flash Version: 

This does not apply to the Win7 "legacy" code.
 
Labels: Needs-Milestone
Labels: TE-NeedsTriageHelp
Project Member

Comment 3 by sheriffbot@chromium.org, May 15 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment