New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717694 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: support resolution of one UI location to multiple raw locations

Project Member Reported by caseq@chromium.org, May 2 2017

Issue description

A location in UISourceCode may represent multiple model-level locations due to merging of scripts or styles, so various uiLocationToRawLocation() methods in Bindings should return multiple locations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/421b9c4b9736e52c903123994d977b4ed406cf72

commit 421b9c4b9736e52c903123994d977b4ed406cf72
Author: caseq <caseq@chromium.org>
Date: Tue May 02 23:59:47 2017

DevTools: support resolving a UILocation to multiple raw script locations

This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array

BUG= 717694 

Review-Url: https://codereview.chromium.org/2857453002
Cr-Commit-Position: refs/heads/master@{#468825}

[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map.html
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3.html
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping.html
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
[modify] https://crrev.com/421b9c4b9736e52c903123994d977b4ed406cf72/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c9853ec9c2a166dc204e64595708202c48dcf26

commit 9c9853ec9c2a166dc204e64595708202c48dcf26
Author: caseq <caseq@chromium.org>
Date: Wed May 03 23:57:17 2017

Revert of DevTools: support resolving a UILocation to multiple raw script locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ )

Reason for revert:
We decided that we don't need that.

Original issue's description:
> DevTools: support resolving a UILocation to multiple raw script locations
>
> This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array
>
> BUG= 717694 
>
> Review-Url: https://codereview.chromium.org/2857453002
> Cr-Commit-Position: refs/heads/master@{#468825}
> Committed: https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d977b4ed406cf72

TBR=dgozman@chromium.org,lushnikov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 717694 

Review-Url: https://codereview.chromium.org/2859073002
Cr-Commit-Position: refs/heads/master@{#469206}

[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map.html
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3.html
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping.html
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
[modify] https://crrev.com/9c9853ec9c2a166dc204e64595708202c48dcf26/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2277d587c39624d35fb97ea65cc610dc29a9306e

commit 2277d587c39624d35fb97ea65cc610dc29a9306e
Author: caseq <caseq@chromium.org>
Date: Thu May 04 19:38:52 2017

DevTools: support uiLocationToRawLocations for CSS

BUG= 717694 

Review-Url: https://codereview.chromium.org/2856233002
Cr-Commit-Position: refs/heads/master@{#469426}

[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping-expected.txt
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/LayoutTests/inspector/sources/formatter-css-expected.txt
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/LayoutTests/inspector/sources/formatter-js-expected.txt
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js
[modify] https://crrev.com/2277d587c39624d35fb97ea65cc610dc29a9306e/third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js

Comment 4 by caseq@chromium.org, May 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment