New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717689 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Page Cycler V2 perf comparison: network service v.s. existing code

Project Member Reported by yzshen@chromium.org, May 2 2017

Issue description

Page Cycler V2 should run at least as fast as before when using the network service.

 
A related (but probably not blocking) issue filed:
  crbug.com/717260 Page Cycler V2: one of the test case records data for both runs of the cache-warm case.
At the moment, timeToOnLoad is roughly on par with the existing code (control group).

Two tests have significantly bigger timeToFirstMeaningfulPaint:
 http://www.nationalgeographic.com/ (658.887 v.s. 311.146)
 http://www.flickr.com/... (790.523 v.s. 106.146)


It turned out people have already seen this issue with nationalgeographic when LoadingWithMojo was enabled, and investigation showed that it was false-positive.

Please see: https://docs.google.com/document/d/1wissv31WUjeHaSaf78uAH0FiFQfSU6sqv14Lcuo1toA/edit#

Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa5e572013e1c46993b8e79da9e55b58a0f2c86e

commit fa5e572013e1c46993b8e79da9e55b58a0f2c86e
Author: yzshen <yzshen@chromium.org>
Date: Tue May 02 21:24:13 2017

Network service: avoid requesting a new URLLoaderFactory for each NavigationURLLoaderNetworkService.

Eventually we will need the ability to customize URL factory per frame, for things like appcache or service worker. But by default we could use a global URL factory.

BUG= 717689 

Review-Url: https://codereview.chromium.org/2854723002
Cr-Commit-Position: refs/heads/master@{#468776}

[modify] https://crrev.com/fa5e572013e1c46993b8e79da9e55b58a0f2c86e/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/fa5e572013e1c46993b8e79da9e55b58a0f2c86e/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/fa5e572013e1c46993b8e79da9e55b58a0f2c86e/content/browser/site_per_process_browsertest.cc

Comment 4 by yzshen@chromium.org, May 24 2017

Components: Internals>Network>Service

Comment 5 by yzshen@chromium.org, Jun 15 2017

Status: Fixed (was: Untriaged)

Comment 6 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment