New issue
Advanced search Search tips

Issue 717684 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox focus ring is offset and doesn't update

Project Member Reported by dmazz...@chromium.org, May 2 2017

Issue description

In M59 the ChromeVox focus ring regressed, it used to correctly outline the bounds of an object, but this change broke it:

r460412
https://codereview.chromium.org/2762373002
"Fix computation of Automation API location offsets in WebViews"

The fix was supposed to be for  bug 658947 , which was that the focus ring was incorrect in the sign-in screen.

The fix worked correctly for the sign-in screen, and was technically an improvement, but it exposed other bugs and the overall result is *worse*, not better.

Since then we've fixed the issue on trunk, however the most recent fix is larger and I'm not sure we want to merge it.

I think the safest solution is to *revert* the above change, on the M59 branch. That brings M59 back to the previous state where it was mostly working fine but off on the sign-in screen. Then in M60 we'll fix the remaining issues so that it works correctly everywhere.

I just did some manual testing on the M59 branch.

Currently, the focus ring is way off. Turn on ChromeVox and tab around any web page to see.

If I revert r460412, it reverts completely cleanly, and virtually all windows and web pages now work fine. The focus ring goes back to being wrong on the sign-in screen, but everywhere else it's correct.

Reverting r460412 on trunk would not be easy because other changes depend on it. Plus, the situation has already been fixed properly on trunk - the focus ring is correct everywhere including the sign-in screen.

 
Project Member

Comment 1 by sheriffbot@chromium.org, May 3 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by sheriffbot@chromium.org, May 8 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9713fc0690986ce27fb417f01fd715016fbaa46

commit e9713fc0690986ce27fb417f01fd715016fbaa46
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon May 08 21:03:02 2017

Merge to M59: Revert "Fix computation of Automation API location offsets in WebViews."

This reverts commit c7c9e55f9f13ae947e938b8a4c929fefdeffe397.

Originally landed: r460412: https://codereview.chromium.org/2762373002

BUG= 717684 , 658947 

Review-Url: https://codereview.chromium.org/2867103005 .
Cr-Commit-Position: refs/branch-heads/3071@{#462}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/common/extensions/chrome_extension_messages.h
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/renderer/extensions/automation_internal_custom_bindings.h
[delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/location_in_webview.js
[delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/manifest.json
[delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html

Labels: -ReleaseBlock-Stable
Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment