New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717682 link

Starred by 1 user
Status: Fixed
Owner:
█ hzl@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ mikec...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Give the table cells onclick and not the strings inside them for results_detail

Project Member Reported by mikec...@chromium.org, May 2 2017 
Quality of life improvement for results_detail webpage

Move the onclick functions to the table cells and not the text in the cells. For some things such as test names. Will make things much easier to click. There might be some situations where some cells might contain multiple links (the "links" cell for example) so this might not be possible everwhere.

What do you think?
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e111db0385aeceaf3e0c03f3f57568f908be46b5

commit e111db0385aeceaf3e0c03f3f57568f908be46b5
Author: hzl <hzl@google.com>
Date: Fri May 19 02:18:14 2017

Make the table cells clickable, instead of the strings inside.

Previously the strings inside table cells on clickable, but it takes
accurate mouse control and aiming.

In this cl, we are making the whole cell clickable,
to make the table easier to use.

BUG= 717682 

Review-Url: https://codereview.chromium.org/2888723002
Cr-Commit-Position: refs/heads/master@{#473035}

[modify] https://crrev.com/e111db0385aeceaf3e0c03f3f57568f908be46b5/build/android/pylib/results/presentation/javascript/main_html.js
[modify] https://crrev.com/e111db0385aeceaf3e0c03f3f57568f908be46b5/build/android/pylib/results/presentation/template/main.html
[modify] https://crrev.com/e111db0385aeceaf3e0c03f3f57568f908be46b5/build/android/pylib/results/presentation/template/table.html

Comment 2 by hzl@chromium.org, May 20 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment