Issue 717676 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	sky@chromium.org
Closed:	May 2017
Cc:	sadrul@chromium.org sky@chromium.org mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Proj-Mustash-Mus mustash-2 VerifyIn-61

mushrome: Ctrl-N doesn't work when all browser windows are closed

Project Member Reported by jamescook@chromium.org, May 2 2017

Issue description

chrome --mus on link and on desktop, Chrome r468701

* Close all browser windows
* Press ash shortcut keys (like Ctrl-N or Ctrl-Shift-Q)
* Nothing happens

Maybe keyboard focus is broken? Or ash isn't an event target in the way it expects?

Comment 1 by sky@chromium.org, May 4 2017

Labels: mustash-2
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by sky@chromium.org, May 5 2017

Status: Started (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9af279fc5d9475d998c2080bb62be6a732279827

commit 9af279fc5d9475d998c2080bb62be6a732279827
Author: sky <sky@chromium.org>
Date: Mon May 08 17:23:49 2017

chromeos: makes mus send keyevents to display root when nothing has focus

Prior to this change if no windows have focus then the KeyEvent is
dropped. This change makes it so that if no windows have focus then
the KeyEvent is targetted to the window manager. This makes it so
accelerators work in mushrome (accelerators in mushrome are
implemented using classic-ash mechanism, *not* as accelerators
registered with mus).

BUG= 717676 
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2863913004
Cr-Commit-Position: refs/heads/master@{#470032}

[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/ash/mus/accelerators/accelerator_controller_registrar.h
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/cursor_unittest.cc
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/display.h
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/window_manager_display_root.cc
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/window_manager_display_root.h
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/window_manager_state.cc
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/window_manager_state.h
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/window_server.cc
[modify] https://crrev.com/9af279fc5d9475d998c2080bb62be6a732279827/services/ui/ws/window_tree_unittest.cc