New issue
Advanced search Search tips

Issue 717669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 717699



Sign in to add a comment

Fix ImageAnimation constant names after Blink renaming

Project Member Reported by cblume@chromium.org, May 2 2017

Issue description

The ImageAnimation constants such as AnimationNone used to be named like cAnimationNone. This didn't match other constants within the image decoders.

After the recent Blink style update, these were renamed like kCAnimationNone, making them even weirder.

They should be like kAnimationNone.
 
Blocking: 717699
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4

commit 83bcead92eb1c2aec8bcb5e50deb6fc2440240f4
Author: cblume <cblume@chromium.org>
Date: Mon May 15 01:41:13 2017

Fix ImageAnimation constant names after Blink renaming

The ImageAnimation constants such as AnimationNone used to be named like
cAnimationNone. This didn't match other constants within the image
decoders.

After the recent Blink style update, these were renamed like
kCAnimationNone, making them even weirder.

They should be like kAnimationNone.

BUG= 717669 

Review-Url: https://codereview.chromium.org/2857753002
Cr-Commit-Position: refs/heads/master@{#471648}

[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/graphics/ImageSource.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/ImageAnimation.h
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp
[modify] https://crrev.com/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp

Comment 3 by cblume@chromium.org, May 15 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/637e16339a326cac9b9065ce0645f0b4574b5093

commit 637e16339a326cac9b9065ce0645f0b4574b5093
Author: cblume <cblume@chromium.org>
Date: Mon May 15 20:36:12 2017

Revert of Fix ImageAnimation constant names after Blink renaming (patchset #4 id:60001 of https://codereview.chromium.org/2857753002/ )

Reason for revert:
Accidentally included false dependency.

Original issue's description:
> Fix ImageAnimation constant names after Blink renaming
>
> The ImageAnimation constants such as AnimationNone used to be named like
> cAnimationNone. This didn't match other constants within the image
> decoders.
>
> After the recent Blink style update, these were renamed like
> kCAnimationNone, making them even weirder.
>
> They should be like kAnimationNone.
>
> BUG= 717669 
>
> Review-Url: https://codereview.chromium.org/2857753002
> Cr-Commit-Position: refs/heads/master@{#471648}
> Committed: https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4

TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 717669 

Review-Url: https://codereview.chromium.org/2878363003
Cr-Commit-Position: refs/heads/master@{#471887}

[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/graphics/ImageSource.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/ImageAnimation.h
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp
[modify] https://crrev.com/637e16339a326cac9b9065ce0645f0b4574b5093/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7ad055459988d9431b8e67118658a4c9cc2d470

commit b7ad055459988d9431b8e67118658a4c9cc2d470
Author: cblume <cblume@chromium.org>
Date: Tue May 16 15:54:08 2017

Reland of Fix ImageAnimation constant names after Blink renaming (patchset #1 id:1 of https://codereview.chromium.org/2878363003/ )

Reason for revert:
Making a patch to re-land after correcting the accidental upstream.

Original issue's description:
> Revert of Fix ImageAnimation constant names after Blink renaming (patchset #4 id:60001 of https://codereview.chromium.org/2857753002/ )
>
> Reason for revert:
> Accidentally included false dependency.
>
> Original issue's description:
> > Fix ImageAnimation constant names after Blink renaming
> >
> > The ImageAnimation constants such as AnimationNone used to be named like
> > cAnimationNone. This didn't match other constants within the image
> > decoders.
> >
> > After the recent Blink style update, these were renamed like
> > kCAnimationNone, making them even weirder.
> >
> > They should be like kAnimationNone.
> >
> > BUG= 717669 
> >
> > Review-Url: https://codereview.chromium.org/2857753002
> > Cr-Commit-Position: refs/heads/master@{#471648}
> > Committed: https://chromium.googlesource.com/chromium/src/+/83bcead92eb1c2aec8bcb5e50deb6fc2440240f4
>
> TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 717669 
>
> Review-Url: https://codereview.chromium.org/2878363003
> Cr-Commit-Position: refs/heads/master@{#471887}
> Committed: https://chromium.googlesource.com/chromium/src/+/637e16339a326cac9b9065ce0645f0b4574b5093

TBR=scroggo@chromium.org,pkasting@chromium.org,noel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 717669 

Review-Url: https://codereview.chromium.org/2884803002
Cr-Commit-Position: refs/heads/master@{#472116}

[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/graphics/ImageSource.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/ImageAnimation.h
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp
[modify] https://crrev.com/b7ad055459988d9431b8e67118658a4c9cc2d470/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp

Sign in to add a comment