New issue
Advanced search Search tips

Issue 717661 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Support UNINSTALL_SHORTCUT

Project Member Reported by khmel@chromium.org, May 2 2017

Issue description

Currently UNINSTALL_SHORTCUT is not support in ARC.

This is also requested by Crossover team.

Inner bug: b/34749139
 

Comment 2 by khmel@chromium.org, May 6 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 6 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fced5a6012d10701e8a5e2d6901949fa035fa1a

commit 2fced5a6012d10701e8a5e2d6901949fa035fa1a
Author: khmel <khmel@chromium.org>
Date: Mon May 08 20:00:06 2017

[Merge M59] arc: Support UNINSTALL_SHORTCUT

This adds handling UNINSTALL_SHORTCUT intent.

BUG= 717661 
BUG=b/34749139
TEST=Manually with test app. Shortcuts added and removed properly.
     Extended unit_tests
TBR=xiyuan@chromium.org,lhchavez@chromium.org,nasko@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2858703002
Cr-Commit-Position: refs/heads/master@{#469063}
(cherry picked from commit cf0b40a80365c1c0de0d70e785ae91a26e547f74)

Review-Url: https://codereview.chromium.org/2861403003
Cr-Commit-Position: refs/branch-heads/3071@{#459}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/2fced5a6012d10701e8a5e2d6901949fa035fa1a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/2fced5a6012d10701e8a5e2d6901949fa035fa1a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/2fced5a6012d10701e8a5e2d6901949fa035fa1a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/2fced5a6012d10701e8a5e2d6901949fa035fa1a/components/arc/common/app.mojom
[modify] https://crrev.com/2fced5a6012d10701e8a5e2d6901949fa035fa1a/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/2fced5a6012d10701e8a5e2d6901949fa035fa1a/components/arc/test/fake_app_instance.h

Comment 5 by khmel@chromium.org, May 8 2017

Status: Fixed (was: Started)
khmel@ Trying to verify this bug. Could you please provide verification steps?

Comment 7 by khmel@chromium.org, May 12 2017

I used test App I wrote to test this feature.
ArcHelloAndroid.apk

Once started it creates 5 shortcuts.
It has button "Uninstall". Once clicked one shortcut should be removed.


ArcHelloAndroid.apk
135 KB Download
Status: Verified (was: Fixed)
Thanks khmel@.

Verified on TOT 9542.0.0, 60.0.3096.0 using above steps.

Sign in to add a comment