New issue
Advanced search Search tips

Issue 717655 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor common code in constructor/stereopanner.html test

Project Member Reported by rtoy@chromium.org, May 2 2017 
There's quite a bit of mostly duplicate code in testing the audio node options for the stereopanner.  Refactor this into a common function.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/989663f900dd134d23133f19170c0b9ce03e6e66

commit 989663f900dd134d23133f19170c0b9ce03e6e66
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Jan 29 16:43:09 2018

Refactor common code in constructor/stereopanner.html

Move the mostly common test code into one method and use it for
testing all of the valid and invalid attributes for the stereo panner.

Bug:  717655 
Change-Id: If6d6347d1fe303bc1c79acf141aa12ce3b04259c
Reviewed-on: https://chromium-review.googlesource.com/879535
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532460}
[modify] https://crrev.com/989663f900dd134d23133f19170c0b9ce03e6e66/third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html

Comment 2 by rtoy@chromium.org, Jan 30 2018

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment