New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717652 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create an end-to-end input event latency test

Project Member Reported by mfomitchev@chromium.org, May 2 2017

Issue description

We need an end-to-end test verifying that input event latency reporting works properly. There recently was a regression that broke UMA input latency metrics reporting, which wasn't caught by any tests (fixed in https://codereview.chromium.org/2847553003/)
 
Components: Speed>Metrics
Labels: Hotlist-Input-Dev
Owner: tdres...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fe8085f9f4f10d88ec704588adea49392303fbe

commit 7fe8085f9f4f10d88ec704588adea49392303fbe
Author: tdresser <tdresser@chromium.org>
Date: Wed May 17 19:57:51 2017

Reduce composited smooth scroll latency by a frame (also fixes latency UMAs).

Previously input which triggered a smooth scroll didn't scroll
at all on the first frame of the smooth scroll animation.

This introduced unnecessary latency, and also prevented out input
latency instrumentation from realizing that the input produced a
frame.

This removes that latency by starting the animation one frame in,
and causes our input latency pipeline to recognize that this input
triggered a frame being drawn.

The main thread case still needs to be fixed.

BUG= 599910 ,  717652 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2863103002
Cr-Commit-Position: refs/heads/master@{#472542}

[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/animation/animation_host.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/animation/animation_host.h
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/animation/animation_host_unittest.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/animation/scroll_offset_animations_impl.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/animation/scroll_offset_animations_impl.h
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/cc/trees/mutator_host.h
[add] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/content/browser/renderer_host/input/scroll_latency_browsertest.cc
[modify] https://crrev.com/7fe8085f9f4f10d88ec704588adea49392303fbe/content/test/BUILD.gn

Status: Fixed (was: Started)
ScrollLatencyBrowserTest appears nonflaky at this point.

https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/scroll_latency_browsertest.cc?q=scroll_latency_b&sq=package:chromium 

Marking this fixed.

Sign in to add a comment