Navigations to hosted app resources not blocked in PlzNavigate |
||
Issue description
1. Open chrome canary, ensure that browser-side navigation is running (c68ab9a3-6edc92c7 should appear on about:version).
2. Open a new tab and navigate it to the manifest of a hosted app ('chrome-extension://apdfllckaahabafndbhieahigkjlhalf/manifest.json' if you have the Google Sheets app installed, which you probably do).
3. The bug is that this page loads successfully, but has its URL rewritten to chrome-extension://invalid/
This does not happen without PlzNavigate -- it is blocked from loading there.
It looks like what's happening is that the URL is rewritten after PlzNavigate has decided that this navigation is okay: bool ChromeExtensionsRendererClient::WillSendRequest().
This should probably be addressed in the ExtensionNavigationThrottle
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e5e6de4f09b9bc50ec0460fcad02d5923304d9 commit 68e5e6de4f09b9bc50ec0460fcad02d5923304d9 Author: nasko <nasko@chromium.org> Date: Wed May 24 23:19:34 2017 Block navigations to hosted apps non-icon resources with PlzNavigate. BUG= 717626 Review-Url: https://codereview.chromium.org/2875493002 Cr-Commit-Position: refs/heads/master@{#474469} [modify] https://crrev.com/68e5e6de4f09b9bc50ec0460fcad02d5923304d9/chrome/browser/extensions/process_manager_browsertest.cc [add] https://crrev.com/68e5e6de4f09b9bc50ec0460fcad02d5923304d9/chrome/test/data/extensions/hosted_app/icon.png [modify] https://crrev.com/68e5e6de4f09b9bc50ec0460fcad02d5923304d9/chrome/test/data/extensions/hosted_app/manifest.json [modify] https://crrev.com/68e5e6de4f09b9bc50ec0460fcad02d5923304d9/extensions/browser/extension_navigation_throttle.cc
,
May 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by nasko@chromium.org
, May 11 2017