Show Extension name in Permission prompt (instead of URLs) |
||||||
Issue description
See attached image. The proposal is that rather than the Chrome extension URL, we show the human readable name as we now do in the Verbose Text of the omnibox security chip.
Chrome Version: 60.0.3087
base::string16 PermissionsBubbleDialogDelegateView::GetWindowTitle() const {
return l10n_util::GetStringFUTF16(IDS_PERMISSIONS_BUBBLE_PROMPT,
display_origin_);
}
,
May 2 2017
The function GetExtensionName(const GURL& url, content::WebContents* web_contents) will prove helpful in your quest. :) (The omnibox code mentioned in #0 is https://codereview.chromium.org/2217643002/)
,
May 16 2017
,
Jun 22 2017
chrahunt@: Are you still interested? Otherwise I'm going to assign this bug.
,
Sep 21 2017
I just put together a CL for this at https://bugs.chromium.org/p/chromium/issues/detail?id=717625&q=Hotlist%3AGoodFirstBug&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified I've attached the test app I used to verify the change, and a screenshot of the result of that test.
,
Sep 21 2017
,
Nov 6 2017
aelder: were you still working on this?
,
Nov 6 2017
I haven't gotten back to this since noticing that my change causes a build failure for android. https://chromium-review.googlesource.com/c/chromium/src/+/677983 If somebody wants to snag this, I won't complain. Otherwise, I'll try to take a look at it again later this week.
,
Nov 10 2017
,
Nov 15 2017
aelder: I think you just need to #if !defined(OS_ANDROID) out the code in permission_request_manager. Android doesn't know about extensions, so it won't compile as is.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202 commit 66bf5121ea3846c2dd3db09e62d64f5cbd0ec202 Author: Adrian Elder <aelder@chromium.org> Date: Tue Nov 28 01:56:33 2017 Show extension name in permission bubble. This applies to browser permissions checks, not app permissions. For example: getUserMedia. If the permission is not requested by an extension, or the extension name cannot be looked up, the origin from the URL is shown as before. Tested by launching an extension that attempts to access the mic with getUserMedia and verifying the existing behavior for a web site. Bug: 717625 Change-Id: I4e17c97f932ee163afa2fe972687259d794e4cfc Reviewed-on: https://chromium-review.googlesource.com/677983 Commit-Queue: Adrian Elder <aelder@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#519520} [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/extensions/extension_ui_util.cc [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/extensions/extension_ui_util.h [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/location_bar/location_bar.cc [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/location_bar/location_bar.h [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/permission_bubble/permission_prompt.h [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/66bf5121ea3846c2dd3db09e62d64f5cbd0ec202/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
,
Nov 28 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mea...@chromium.org
, May 2 2017Status: Available (was: Untriaged)