New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717619 link

Starred by 1 user
Status: Fixed
Owner:
█ ti...@chromium.org
Email to this user bounced
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Increase the number of extra characters for smart text selection to 240 characters

Reported by ti...@chromium.org, May 2 2017 
This is the request from Android team:

Could we increase the context from 100 (i.e. 50 each side) to 240 characters (i.e. 120 each side) [for WebView]? It would match what we do in EditText. We found out that context of 50 characters from each side is not enough to ensure symmetry of selections in some cases, and also if there is a long URL it results in it being cut in the middle.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a999e72fd81a030338d60785a2e6e09427fad811

commit a999e72fd81a030338d60785a2e6e09427fad811
Author: timav <timav@chromium.org>
Date: Wed May 03 17:29:38 2017

[SmartText Selecton] Increase the number of extra characters to 240

This is the maximal amount of characters from the left and from the right
taken together, i.e. there is 120 on each side.

BUG= 717619 

Review-Url: https://codereview.chromium.org/2862503002
Cr-Commit-Position: refs/heads/master@{#469019}

[modify] https://crrev.com/a999e72fd81a030338d60785a2e6e09427fad811/content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

Comment 2 Deleted

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6d07bd554bd69ad7d577fd23add6c677e9ae1ee

commit f6d07bd554bd69ad7d577fd23add6c677e9ae1ee
Author: Tima Vaisburd <timav@chromium.org>
Date: Wed May 03 17:37:24 2017

[SmartText Selecton] Increase the number of extra characters to 240

This is the maximal amount of characters from the left and from the right
taken together, i.e. there is 120 on each side.

BUG= 717619 

Review-Url: https://codereview.chromium.org/2862503002
Cr-Commit-Position: refs/heads/master@{#469019}
(cherry picked from commit a999e72fd81a030338d60785a2e6e09427fad811)

Review-Url: https://codereview.chromium.org/2857193002 .
Cr-Commit-Position: refs/branch-heads/3071@{#375}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f6d07bd554bd69ad7d577fd23add6c677e9ae1ee/content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java

Comment 5 by ti...@chromium.org, May 3 2017

Status: Fixed (was: Assigned)

Comment 6 by boliu@chromium.org, May 3 2017 

where's the merge request/approval?

Comment 7 by ti...@chromium.org, May 3 2017 

Forgot.

Comment 8 by ti...@chromium.org, May 3 2017 

Does it make sense to request now?

Comment 9 by boliu@chromium.org, May 3 2017 

it's not ok to forget these things. being a committer means you know and follow the rules

Comment 10 by ti...@chromium.org, May 3 2017 

Yes, I agree this is bad. What is the best way to fix the situation right now? E.g., request the merge? Revert the change and then request the merge?

Comment 11 by boliu@chromium.org, May 3 2017 

it probably would have been auto-approved already, so don't really need to do anything
►

Sign in to add a comment