New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717616 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 392354



Sign in to add a comment

Open links on interstitials in a new tab

Project Member Reported by mea...@chromium.org, May 2 2017

Issue description

Currently if the user clicks a link on an interstitial (e.g. Privacy Policy), the link opens in the same tab. Since interstitial navigations aren't added to history, going back simply takes them to the previous page, skipping the interstitial.

This makes clicking links pretty painful, we should consider opening them in a new tab until the great interstitial refactor happens.
 
Blocking: 392354

Comment 2 by mea...@chromium.org, Jun 22 2017

Owner: sperigo@chromium.org
Status: Assigned (was: Available)
sperigo: Assigning to you. You can visit https://wrong.host.badssl.com to see a real interstitial (instead of the mock ones at chrome://interstitials).

You'll notice that clicking on the links open them in the same tab. Would be better to open them in a new tab. You can find where the code lives by doing string search in Chrome code search.

Comment 3 Deleted

Cc: ntfschr@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2820c5be459b2a37f590580ae9b1a14cea967020

commit 2820c5be459b2a37f590580ae9b1a14cea967020
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed Jun 28 02:40:58 2017

SafeBrowsing: add SBErrorDisplayOptions.should_open_links_in_new_tab

No change in logic.

This adds a should_open_links_in_new_tab to SBErrorDisplayOptions. This
value is set to true for chrome and false for WebView. This does not use
the value, but this is done in preparation for
https://codereview.chromium.org/2955503002/.

This is needed for WebView, since WebView doesn't have a notion of
multiple tabs, and we can't easily create a second webview for Safe
Browsing links.

Bug:  717616 
Change-Id: I7045e73027a931ef0ae0c6c87b0cd0a2f2d50194
Reviewed-on: https://chromium-review.googlesource.com/550938
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482859}
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/android_webview/browser/aw_safe_browsing_blocking_page.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/components/safe_browsing/triggers/trigger_manager.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/components/security_interstitials/core/base_safe_browsing_error_ui.cc
[modify] https://crrev.com/2820c5be459b2a37f590580ae9b1a14cea967020/components/security_interstitials/core/base_safe_browsing_error_ui.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22cb4d1b1f6afc95aba0eb04246c13fe178697e

commit a22cb4d1b1f6afc95aba0eb04246c13fe178697e
Author: sperigo <sperigo@chromium.org>
Date: Thu Jun 29 00:50:10 2017

Make interstitial links open in a new tab

BUG= 717616 

https: //badssl.com and make sure that the various info links open in a
Review-Url: https://codereview.chromium.org/2955503002
Cr-Commit-Position: refs/heads/master@{#483231}

[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/content/security_interstitial_controller_client.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/content/security_interstitial_controller_client.h
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/content/security_interstitial_page.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/content/security_interstitial_page.h
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/core/controller_client.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/core/controller_client.h
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/core/safe_browsing_loud_error_ui.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/core/safe_browsing_loud_error_ui.h
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/core/ssl_error_ui.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/components/security_interstitials/core/superfish_error_ui.cc
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/ios/chrome/browser/interstitials/ios_chrome_controller_client.h
[modify] https://crrev.com/a22cb4d1b1f6afc95aba0eb04246c13fe178697e/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome Canary version: 61.0.3148.0
Device : iPhone 6s plus, iPad Air
iOS :  10.3.1. 10.3.2

Verified following the steps mentioned in comment #3.  Tapping on "Learn More" on https://wrong.host.badssl.com opens in a new tab.  Looks good.

Sign in to add a comment