Many tests have implemented this code, but it would be ideal to have it in a shared location. There are issues when scrolling to find labels, it would be good to have this logic in one method.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/959c01304869349d98de2df8775f7209a240dad8 commit 959c01304869349d98de2df8775f7209a240dad8 Author: baxley <baxley@chromium.org> Date: Wed May 10 17:17:12 2017 Make settings_egtest.mm work in landscape on small phones. Create ChromeEarlGreyUI methods to tap menu buttons, where it will scroll and make sure the button is visible. BUG= 717614 Review-Url: https://codereview.chromium.org/2867553002 Cr-Commit-Position: refs/heads/master@{#470626} [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/959c01304869349d98de2df8775f7209a240dad8/ios/chrome/test/earl_grey/chrome_matchers.mm
Comment 1 by baxley@chromium.org
, May 2 2017Status: Assigned (was: Available)