New issue
Advanced search Search tips

Issue 717612 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

ChromeOS build failing

Project Member Reported by anthonyvd@chromium.org, May 2 2017

Issue description

Need to change "return view" to "return std::move(view)" ?
Status: Started (was: Assigned)
Yep, that's what I'm thinking. It's currently landing: https://codereview.chromium.org/2853373003
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf16ab86c8929ad72134db3d09bd3681e70bd9e9

commit bf16ab86c8929ad72134db3d09bd3681e70bd9e9
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue May 02 18:53:02 2017

[Web Payments] Explicitly move SheetView

BUG= 717612 

Review-Url: https://codereview.chromium.org/2853373003
Cr-Commit-Position: refs/heads/master@{#468723}

[modify] https://crrev.com/bf16ab86c8929ad72134db3d09bd3681e70bd9e9/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

Status: Fixed (was: Started)
This should now be fixed, please reopen otherwise.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment