New issue
Advanced search Search tips

Issue 717609 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Chrome Translate is not working when Preload webpages is set to Only Wifi / Always

Project Member Reported by jdhakshinamoor@chromium.org, May 2 2017

Issue description

App Version: 60.0.3080.0 dev,  59.0.3071.30 dev
iOS Version: 10.3
Device: iPhone, iPad
URL: dinamalar.com , mail.ru ,www.rtve.es 


Steps to reproduce:
1. Launch Google Chrome
2. Tap on Menu > Settings 
3. Tap on Bandwidth
4. Navigate to Preload Webpages 
5. Set Preload Webpages = Only on Wifi / Always
6. Navigate to any URL 


Observed results: 
Translation toast msg is missing when Preload Webpages is set to Wifi / Always. 

Note: This issue appears only Bandwidth > Preload > Only wifi & Always
but not reproducible when set to NEVER. 

Expected results: 
Chrome Translate should be working at all times

Number of times you were able to reproduce: 4/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Dolphin/Safari/Atomic: Dolphin: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M58, No
Bug reproducible on the current beta channel build (App Version, iOS Version): M59 Yes

Type-bug-regression? Yes

Link to video/image: 
https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mR1psY2FxTTFteHc/view

Preload - Wifi , Always
https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mTXZ5OGlwbWQxRE0/view

Preload-Never - Translation toast msg appears
https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mVWlKV2tKMTJGTEE/view

 
Description: Show this description
Labels: -OS-Linux -Type-Bug Type-Bug-Regression

Comment 3 by sczs@chromium.org, May 3 2017

Labels: M-59 ReleaseBlock-Stable
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)
michaeldo@ could you please take a look.
Status: Started (was: Assigned)
Code review in progress: https://codereview.chromium.org/2868433003/
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79909fbb894fa48c8a45a4de6079812668ee2da1

commit 79909fbb894fa48c8a45a4de6079812668ee2da1
Author: michaeldo <michaeldo@chromium.org>
Date: Tue May 09 23:42:50 2017

Ensure InfoBarManager is moved when preload tab is set as current tab.

BUG= 717609 

Review-Url: https://codereview.chromium.org/2868433003
Cr-Commit-Position: refs/heads/master@{#470436}

[modify] https://crrev.com/79909fbb894fa48c8a45a4de6079812668ee2da1/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Started)
Labels: Merge-Request-59
Project Member

Comment 8 by sheriffbot@chromium.org, May 10 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: Less than 23 days to go before AppStore submit on M59
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by cma...@chromium.org, May 11 2017

Cc: vbhatso...@chromium.org
vbhatsoori@ please verify
Status: Verified (was: Fixed)
Verified in build 60.0.3096.0 Canary on iPad Pro iOS 10.2.1, iPhone7+ iOS 10.2.1 , 
iPad Mini iOS 10.3
https://drive.google.com/open?id=0B6GVWQnhaMClVkg0RHcybTVIZTQ
Labels: -Hotlist-Merge-Review -Merge-Review-59 Merge-Approved-59
Project Member

Comment 12 by bugdroid1@chromium.org, May 15 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4e5b9563fb83e9bc95601d1f800f9149b532f1

commit 7c4e5b9563fb83e9bc95601d1f800f9149b532f1
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Mon May 15 15:51:18 2017

Ensure InfoBarManager is moved when preload tab is set as current tab.

BUG= 717609 

Review-Url: https://codereview.chromium.org/2868433003
Cr-Original-Commit-Position: refs/heads/master@{#470436}
Review-Url: https://codereview.chromium.org/2883053002 .
Cr-Commit-Position: refs/branch-heads/3071@{#553}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/7c4e5b9563fb83e9bc95601d1f800f9149b532f1/ios/chrome/browser/ui/browser_view_controller.mm

Verified on M59.0.3071.61 beta
Device: iPhone7 plus, iOS: 10.3.2

Translate infobar is displayed for pre-loaded webpages.

Sign in to add a comment