https://codereview.chromium.org/2853163002 Findit notified this code-review, but the /waterfall/culprit shows no builds. https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.chromiumos/ChromiumOS%20x86-generic%20Compile/35068 We need to figure out why the list on /waterfall/culprit is empty, and maybe notify only when we have try-job result.
Notify when only with heuristic result is a special case we have since the confidence level was high enough. But the confidence score seems dropped, I agree we may want to remove this special case.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/22ad4993290cf37ee5d7fd7018fd358d55e5473f commit 22ad4993290cf37ee5d7fd7018fd358d55e5473f Author: Chan <chanli@chromium.org> Date: Tue May 02 19:05:13 2017 [Findit] Remove the special case to send notification to code review. Findit has a special case to send notification when Findit only has heuristic results for compile failures. Now this case seems not necessary, so remove it. Bug: 717605 Change-Id: I3c3a5da82db6e28cdbe0266752b9b16b644af691 Reviewed-on: https://chromium-review.googlesource.com/493609 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/22ad4993290cf37ee5d7fd7018fd358d55e5473f/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py [modify] https://crrev.com/22ad4993290cf37ee5d7fd7018fd358d55e5473f/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py [modify] https://crrev.com/22ad4993290cf37ee5d7fd7018fd358d55e5473f/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py [modify] https://crrev.com/22ad4993290cf37ee5d7fd7018fd358d55e5473f/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
Comment 1 by chanli@chromium.org
, May 2 2017