New issue
Advanced search Search tips

Issue 717601 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Audit uses of UpdateStyleAndLayoutIgnorePendingStylesheetsForNode vs EnsureLifecycleValidForLocationAPIsForNode

Project Member Reported by smcgruer@chromium.org, May 2 2017

Issue description

CL https://codereview.chromium.org/2825343003 creates a new API, EnsureLifecycleValidForLocationAPIsForNode (possibly to be renamed as part of the ongoing CL), which is similar to UpdateStyleAndLayoutIgnorePendingStylesheetsForNode but also runs compositing inputs clean if necessary for sticky elements.

During the review of the CL, a concern was raised that we may have missed some call-sites where EnsureLifecycleValidForLocationAPIsForNode should be used instead of UpdateStyleAndLayoutIgnorePendingStylesheetsForNode (i.e. a callsite that requires the location to be valid). 

Replacing all calls to UpdateStyleAndLayoutIgnorePendingStylesheetsForNode is not desirable as there is a performance impact to running compositing inputs clean, but we should audit the call-sites to try and spot any that rely on location information.
 

Comment 1 by f...@opera.com, May 2 2017

Cc: f...@opera.com

Comment 2 Deleted

Comment 3 Deleted

Labels: -Type-Bug Type-Task
Status: WontFix (was: Assigned)
In hindsight, this bug hasn't been very useful. We never got around to auditing the calls, and instead have been dealing with lifecycle-related sticky bugs as and when they come up.

Sign in to add a comment