This should be replaced by the throttle manager and the chrome client.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8f2850cf1004785650d0ab597c4b517aa8204a2 commit f8f2850cf1004785650d0ab597c4b517aa8204a2 Author: csharrison <csharrison@chromium.org> Date: Thu May 04 14:52:48 2017 Make ChromeSubresourceFilterClient a WebContentsUserData This also modifies the ownership of the subresource filter client, which now must outlive the throttle manager / driver factory. BUG= 717590 Review-Url: https://codereview.chromium.org/2850373002 Cr-Commit-Position: refs/heads/master@{#469331} [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/chrome/browser/ui/tab_helpers.cc [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc [modify] https://crrev.com/f8f2850cf1004785650d0ab597c4b517aa8204a2/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77bf83460738f6b1465d016ccfc26e930babfc00 commit 77bf83460738f6b1465d016ccfc26e930babfc00 Author: csharrison <csharrison@chromium.org> Date: Thu May 04 18:23:10 2017 [subresource_filter] Move throttle insertion into the client This patch also makes the SB throttle pass-through if there isn't a valid DB manager. BUG= 717590 Review-Url: https://codereview.chromium.org/2858483003 Cr-Commit-Position: refs/heads/master@{#469388} [modify] https://crrev.com/77bf83460738f6b1465d016ccfc26e930babfc00/chrome/browser/BUILD.gn [modify] https://crrev.com/77bf83460738f6b1465d016ccfc26e930babfc00/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/77bf83460738f6b1465d016ccfc26e930babfc00/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/77bf83460738f6b1465d016ccfc26e930babfc00/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [delete] https://crrev.com/7093bce085613efd785b72f2a66ee8be27f7d6ed/chrome/browser/subresource_filter/navigation_throttle_util.cc [delete] https://crrev.com/7093bce085613efd785b72f2a66ee8be27f7d6ed/chrome/browser/subresource_filter/navigation_throttle_util.h [modify] https://crrev.com/77bf83460738f6b1465d016ccfc26e930babfc00/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c425f992cc443505b84998b0e20330592ff6393 commit 8c425f992cc443505b84998b0e20330592ff6393 Author: csharrison <csharrison@chromium.org> Date: Sat May 20 22:45:54 2017 [subresource_filter] Move OnReloadRequested to the ChromeClient This functionality is only needed in the //chrome layer. This CL doesn't change behavior. BUG= 717590 Review-Url: https://codereview.chromium.org/2890253002 Cr-Commit-Position: refs/heads/master@{#473453} [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/chrome/browser/ui/android/content_settings/subresource_filter_infobar_delegate.cc [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/chrome/browser/ui/content_settings/content_setting_bubble_model.cc [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/8c425f992cc443505b84998b0e20330592ff6393/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb7da5949a9529ba0b63ab06e76cd4a8c351db26 commit fb7da5949a9529ba0b63ab06e76cd4a8c351db26 Author: csharrison <csharrison@chromium.org> Date: Tue May 23 18:47:00 2017 [subresource_filter] Move driver factory tests to the SB throttle BUG= 717590 Review-Url: https://codereview.chromium.org/2887253004 Cr-Commit-Position: refs/heads/master@{#474000} [modify] https://crrev.com/fb7da5949a9529ba0b63ab06e76cd4a8c351db26/components/subresource_filter/content/browser/BUILD.gn [delete] https://crrev.com/0a2243c09c7513d55bde53ceeae0ea89a8334e79/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc [modify] https://crrev.com/fb7da5949a9529ba0b63ab06e76cd4a8c351db26/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/fb7da5949a9529ba0b63ab06e76cd4a8c351db26/components/subresource_filter/core/common/activation_decision.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c47dcd1fde8e0434cd6094974ed51d54a88a44a9 commit c47dcd1fde8e0434cd6094974ed51d54a88a44a9 Author: csharrison <csharrison@chromium.org> Date: Tue May 23 21:45:38 2017 [subresource_filter] Add observer interface for page activation Right now the throttle manager is the only consumer of the API, but in a followup we will make the SubresourceFilterMetricsObserver. BUG= 717590 Review-Url: https://codereview.chromium.org/2894813003 Cr-Commit-Position: refs/heads/master@{#474071} [modify] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/BUILD.gn [modify] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [add] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/subresource_filter_observer.h [add] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/subresource_filter_observer_manager.cc [add] https://crrev.com/c47dcd1fde8e0434cd6094974ed51d54a88a44a9/components/subresource_filter/content/browser/subresource_filter_observer_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ded86c6fc10f0fde6d3dba373fffc002289e3fbd commit ded86c6fc10f0fde6d3dba373fffc002289e3fbd Author: csharrison <csharrison@chromium.org> Date: Wed Jun 07 01:39:17 2017 [subresource_filter] Use the SubresourceFilterObserver for PageLoadMetrics This was the final non-test client of the ActivationDecision persisted in the driver factory. Follow up CLs will remove that member. BUG= 717590 Review-Url: https://codereview.chromium.org/2893183002 Cr-Commit-Position: refs/heads/master@{#477507} [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/chrome/browser/ui/tab_helpers.cc [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/ded86c6fc10f0fde6d3dba373fffc002289e3fbd/components/subresource_filter/content/browser/subresource_filter_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19f5599256144174d54c1ce9d741bf853bfab56c commit 19f5599256144174d54c1ce9d741bf853bfab56c Author: Charles Harrison <csharrison@chromium.org> Date: Thu Aug 17 17:53:25 2017 [subresource_filter] Remove API for getting the last ActivationDecision We now have an observer interface to do this, so tests which relied on this API now use a custom test observer. This CL does not change non-test behavior. A followup should be able to remove the |activation_decision_| member on CSFDF. Bug: 717590 Change-Id: I0c3823241d734b5e045b757ee1ff49a2608e1840 Reviewed-on: https://chromium-review.googlesource.com/537553 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#495213} [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.cc [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/19f5599256144174d54c1ce9d741bf853bfab56c/components/subresource_filter/content/renderer/subresource_filter_agent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/352bdd592ddb21a3436a6214127e2117a648206a commit 352bdd592ddb21a3436a6214127e2117a648206a Author: Charlie Harrison <csharrison@chromium.org> Date: Tue May 22 14:39:30 2018 Add NavigationConsoleLogger This class stores console messages to be logged once a navigation commits. This replaces state storage in ContentSubresourceFilterDriverFactory, which can soon be removed. Bug: 717590 Change-Id: Iff175eb98900844c34bb1a368b2a33b8cfd4098b Reviewed-on: https://chromium-review.googlesource.com/1067124 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560573} [modify] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/BUILD.gn [modify] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [add] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/navigation_console_logger.cc [add] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/navigation_console_logger.h [add] https://crrev.com/352bdd592ddb21a3436a6214127e2117a648206a/components/subresource_filter/content/browser/navigation_console_logger_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48f0b6a055f029283d3657f3213279b48f2080e6 commit 48f0b6a055f029283d3657f3213279b48f2080e6 Author: Charlie Harrison <csharrison@chromium.org> Date: Wed May 23 17:00:53 2018 Move ActivationState computation into Configuration There are is one major change this CL causes We stop setting enable_logging = true in warning mode. Since warning mode does not log messages anyways (we only log disallowed loads). This has no behavior change. We also remove an API that is only used to DCHECK a condition. Forced activation is going away soon anyway and this property is not important to check. Bug: 717590 Change-Id: I9f76dc09bd667e53e1e4c28b58c824f56e1f1680 Reviewed-on: https://chromium-review.googlesource.com/1067645 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#561126} [modify] https://crrev.com/48f0b6a055f029283d3657f3213279b48f2080e6/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/48f0b6a055f029283d3657f3213279b48f2080e6/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/48f0b6a055f029283d3657f3213279b48f2080e6/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/48f0b6a055f029283d3657f3213279b48f2080e6/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/48f0b6a055f029283d3657f3213279b48f2080e6/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/48f0b6a055f029283d3657f3213279b48f2080e6/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d13e50628a920ee217800d5f303da11b9a95a16d commit d13e50628a920ee217800d5f303da11b9a95a16d Author: Charlie Harrison <csharrison@chromium.org> Date: Wed May 23 21:01:02 2018 Move defensive UI code to the throttle manager The CL also adds a test for this case. Bug: 717590 Change-Id: I4e5b9f44df57a882183fef46d20c0753993851fc Reviewed-on: https://chromium-review.googlesource.com/1069182 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561252} [modify] https://crrev.com/d13e50628a920ee217800d5f303da11b9a95a16d/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/d13e50628a920ee217800d5f303da11b9a95a16d/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/d13e50628a920ee217800d5f303da11b9a95a16d/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/d13e50628a920ee217800d5f303da11b9a95a16d/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/542212ef83e8d0b718a57eb0b2c59b4f0402d37e commit 542212ef83e8d0b718a57eb0b2c59b4f0402d37e Author: Charlie Harrison <csharrison@chromium.org> Date: Tue May 29 18:12:44 2018 Remove SubresourceFilterClient::OnNewNavigationStarted This is replaced by having ChromeSubresourceFilterClient be a WebContentsObserver. Additionally, this CL moves ThrottleManager ownership into ChromeSubresourceFilterClient, which simplifies the SubresourceFilterClient API. This CL has no intended behavior change. Bug: 717590 Change-Id: I732366271b1cbddc31fe91fd87b63d36eea15101 Reviewed-on: https://chromium-review.googlesource.com/1067099 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#562508} [modify] https://crrev.com/542212ef83e8d0b718a57eb0b2c59b4f0402d37e/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/542212ef83e8d0b718a57eb0b2c59b4f0402d37e/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/542212ef83e8d0b718a57eb0b2c59b4f0402d37e/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/542212ef83e8d0b718a57eb0b2c59b4f0402d37e/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/542212ef83e8d0b718a57eb0b2c59b4f0402d37e/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/542212ef83e8d0b718a57eb0b2c59b4f0402d37e/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d94c1d3fd49150b5cd2872df17f5411969238b8 commit 6d94c1d3fd49150b5cd2872df17f5411969238b8 Author: Charlie Harrison <csharrison@chromium.org> Date: Thu May 31 02:33:01 2018 Remove forced activation This CL has one major behavior change: Forcing activation via the devtools setting simulates the current site being on the blacklist. This means it will get full UI and settings treatment. Fallout from this change is: 1. Remove the driver factory entirely, and put the SubresourceFilterClient in the throttle manager 2. Refactor the SubresourceFilterClient to make its activation overriding more flexible (and put devtools stuff there). This moves all devtools knowledge out of //components layer. TBR=avi@chromium.org Bug: 717590 , 846733 Change-Id: Ifeff329499f9d39f1140b4c34643e67d6a79d0ab Reviewed-on: https://chromium-review.googlesource.com/1066898 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#563126} [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_abusive_unittest.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_devtools_browsertest.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_test_harness.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/chrome/browser/ui/tab_helpers.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/BUILD.gn [delete] https://crrev.com/b4283ffba108e3d9ae5de968e56b38e8ff7c7571/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [delete] https://crrev.com/b4283ffba108e3d9ae5de968e56b38e8ff7c7571/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/components/subresource_filter/core/common/activation_decision.h [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6d94c1d3fd49150b5cd2872df17f5411969238b8/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, May 4 2017