Update UI for CUPS printing notifications |
||||
Issue descriptionPer UI review, the notifications for printing via CUPS look empty/space usage is not quite right. We should update these to conform to notification UI specs.
,
May 3 2017
Also, xdai@ - Do you know what the character limit for truncating is (accounting for internationalization of the text)?
,
May 8 2017
,
May 8 2017
weifangsun@, the character limit is calculated by (notification width in pixels per line) * (line limit) / (min. pixels per character). For notification title, the character limit is 180 characters. And for notification description, the character limit is either 600 characters (if title has 0 or 1 line) or 360 characters (if title has 2 lines).
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb457134c0afdd23c2547993b9843f4d30594a65 commit bb457134c0afdd23c2547993b9843f4d30594a65 Author: xdai <xdai@chromium.org> Date: Tue May 09 03:50:30 2017 [CUPS] Update UI for CUPS printing notifications. BUG= 717587 Review-Url: https://codereview.chromium.org/2872733002 Cr-Commit-Position: refs/heads/master@{#470168} [modify] https://crrev.com/bb457134c0afdd23c2547993b9843f4d30594a65/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/bb457134c0afdd23c2547993b9843f4d30594a65/chrome/browser/chromeos/printing/cups_print_job_notification.cc
,
May 9 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by weifangsun@chromium.org
, May 3 2017Owner: x...@chromium.org