Update string for PPD selection dialog for CUPS printer setup |
||||||
Issue descriptionCurrently, if a PPD is not automatically configured for a printer during printer setup, a dialog will appear with the following text at the top: "Could not detect your printer model. Select a manufacturer and model from the list." Per UI review, we need to update this to make it clearer that this is an info string rather than an error.
,
May 2 2017
,
May 3 2017
Let's update the string to "Select a manufacturer and model from the list."
,
May 3 2017
Proposal: Can we remove the string all together. The dialog itself is pretty self explanatory. Also, there has been an update on the dialog spec and we are removing the stroke under all Dialog titles. Attached PNG.
,
May 3 2017
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccedf2b29faaf7d66f4270a6e2a8cdf70a6d2f37 commit ccedf2b29faaf7d66f4270a6e2a8cdf70a6d2f37 Author: xdai <xdai@chromium.org> Date: Tue May 09 20:18:10 2017 [CUPS] Remove the string in manufaturer-model-dialog. BUG= 717584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2871643003 Cr-Commit-Position: refs/heads/master@{#470412} [modify] https://crrev.com/ccedf2b29faaf7d66f4270a6e2a8cdf70a6d2f37/chrome/app/settings_strings.grdp [modify] https://crrev.com/ccedf2b29faaf7d66f4270a6e2a8cdf70a6d2f37/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/ccedf2b29faaf7d66f4270a6e2a8cdf70a6d2f37/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
May 9 2017
The string was removed as suggested in #4.
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weifangsun@chromium.org
, May 2 2017