Warning/message when compiling vulkan-validation-layers |
|||||
Issue description
After syncing this morning, I'm seeing the following message appear when compiling chrome:
../../third_party/vulkan-validation-layers/src/loader/loader.c:222:9: warning: Warning: Falling back to non-secure getenv for environmental lookups! Consider updating to a different libc. [-W#pragma-messages]
#pragma message("Warning: Falling back to non-secure getenv for environmental lookups! Consider" \
^
1 warning generated.
Is this known/expected? If so, should we be suppressing the warning? If not, we should fix it.
,
May 2 2017
No, I've never seen this warning. I don't know if something changed or not. Will investigate, probably can just suppress it.
,
May 2 2017
Oh, actually, it's probably related to Frank's enabling of Linux. Assigning to Frank. Just noticed this was Linux.
,
May 2 2017
,
May 2 2017
Escalating priority.
,
May 2 2017
Support for the Vulkan back-end was disabled on Linux in https://chromium.googlesource.com/angle/angle/+/0d4340463c9641c70edc891859fcb7d513f13d39. Will be fixed with the next roll. Leaving Pri-1 until we roll out.
,
May 2 2017
Frank, I think we can just go ahead and define HAVE_SECURE_GETENV in angle's Vulkan BUILD.gn and GYP. It's probably safe to assume we have these on Linux. The loader shouldn't be spamming a warning here but let's just move forward with a quick fix. I think the reason the bots aren't complaining here is that although the message loudly proclaims "WARNING BLAH BLAH" this is in fact a #pragma message not a #pragma warning and hence it is not a warning, but a message. Lowering priority as this isn't actually breaking any builds, but just causing spam and confusion (should still be fixed quickly).
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/f231232b012b43c0365b617890de66d0185197eb commit f231232b012b43c0365b617890de66d0185197eb Author: Frank Henigman <fjhenigman@chromium.org> Date: Tue May 02 21:26:03 2017 vulkan: assume secure_getenv(). Vulkan's cmake files check for the availability of secure_getenv() but we just assume it exists. BUG= chromium:717558 Change-Id: I22054c3967f543d163dde37b9a6b13e896da7a50 Reviewed-on: https://chromium-review.googlesource.com/494126 Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/f231232b012b43c0365b617890de66d0185197eb/src/vulkan_support/BUILD.gn [modify] https://crrev.com/f231232b012b43c0365b617890de66d0185197eb/src/vulkan_support/vulkan.gypi
,
May 2 2017
This is harmless for the moment, and should go away with the next angle roll (daily Mon-Thu).
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97af8a5b4bd46c78ecb55287d6c680b0232bef6d commit 97af8a5b4bd46c78ecb55287d6c680b0232bef6d Author: cwallez <cwallez@chromium.org> Date: Wed May 03 15:54:45 2017 Roll ANGLE d262799..ba29fa4 https://chromium.googlesource.com/angle/angle.git/+log/d262799..ba29fa4 BUG= chromium:717558 , chromium:717385 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2860743002 Cr-Commit-Position: refs/heads/master@{#468988} [modify] https://crrev.com/97af8a5b4bd46c78ecb55287d6c680b0232bef6d/DEPS
,
May 30 2018
I believe this is fixed and we can close this, right? I am building with Vulkan enabled and do not see this warning message any more.
,
May 31 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cwallez@chromium.org
, May 2 2017