Check if IIRFilter is stable. |
||
Issue descriptionCurrently, any possible filter coefficients are allowed for an IIRFilterNode. However, not all of these filters are stable. It would be very useful if Chrome could print a warning if the filter isn't stable. This is also useful for computing the tail time. If the filter isn't stable, the tail time is infinity.
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0602af69e19b44bbbbc64165766098d9c9e36a6 commit d0602af69e19b44bbbbc64165766098d9c9e36a6 Author: rtoy <rtoy@chromium.org> Date: Mon May 15 17:55:25 2017 Print warning if IIR filter is unstable If the specified IIR filter is unstable, print a warning message to the console. However, the IIR filter is still created successfully. BUG= 717556 TEST=IIRFilter/iir-unstable.html Review-Url: https://codereview.chromium.org/2857833003 Cr-Commit-Position: refs/heads/master@{#471823} [modify] https://crrev.com/d0602af69e19b44bbbbc64165766098d9c9e36a6/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html [add] https://crrev.com/d0602af69e19b44bbbbc64165766098d9c9e36a6/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iir-unstable-expected.txt [add] https://crrev.com/d0602af69e19b44bbbbc64165766098d9c9e36a6/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iir-unstable.html [modify] https://crrev.com/d0602af69e19b44bbbbc64165766098d9c9e36a6/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
,
May 17 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, May 8 2017Status: Started (was: Available)