New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717549 link

Starred by 1 user
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Add performance test for ImageData.dataUnion

Project Member Reported by zakerinasab@chromium.org, May 2 2017 
In codereview.chromium.org/2797213002/ we put color managed CRC2D.createImageData() behind the experimental canvas features flag. As a result, getImageDataColorManaged.html performance test started to fail on the perf try bots. For now the test is removed in codereview.chromium.org/2855683002/. We need to add the test later if we found a way to run the perf try bot with a run-time flag or when we shipped the API.
getImageDataColorManaged.html
3.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c4a925b1a047a296b7962566ff63918f3eba1c4

commit 4c4a925b1a047a296b7962566ff63918f3eba1c4
Author: zakerinasab <zakerinasab@chromium.org>
Date: Tue May 02 20:34:28 2017

Add performance test for ImageData.dataUnion

In codereview.chromium.org/2855683002/ the performace test for ImageData.dataUnion
was removed as it was failing on try-bots. To make it work, we need both
--enable-experimental-canvas-features and --enable-color-correct-rendering flags
to be enabled in blink_perf.py. This CL fixes this and puts the perf test back.

BUG= 717549 

Review-Url: https://codereview.chromium.org/2853333002
Cr-Commit-Position: refs/heads/master@{#468764}

[add] https://crrev.com/4c4a925b1a047a296b7962566ff63918f3eba1c4/third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html
[modify] https://crrev.com/4c4a925b1a047a296b7962566ff63918f3eba1c4/tools/perf/benchmarks/blink_perf.py

Comment 2 by zakerinasab@chromium.org, May 3 2017

Status: Fixed (was: Assigned)

Comment 3 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment