New issue
Advanced search Search tips

Issue 717540 link

Starred by 1 user
Status: Fixed
Owner:
stkhapugin@chromium.org
Closed: Feb 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 652732
Blocking:
issue 636372



Sign in to add a comment

Remove scoped/weak NSObjects from ios headers when everything is built with ARC

Project Member Reported by stkhapugin@chromium.org, May 2 2017 
Once every file is built with ARC, the following things should be done:

scoped_nsobject in headers should become *explicit* __strong 
WeakNSObject in headers should become explicit __weak where possible
__unsafe_unretained variables and unsafe_unretained properties should
mostly become weak.

Comment 1 by jasonkliu@chromium.org, May 5 2017

Labels: Hotlist-Needs-New-Component

Comment 2 by eugene...@chromium.org, May 30 2017

Components: Internals
Labels: -Hotlist-Needs-New-Component

Comment 3 by stkhapugin@chromium.org, Aug 17 2017

Blockedon: 652732
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f0c8af9293405f71ca189f48b46dbd21415a993a

commit f0c8af9293405f71ca189f48b46dbd21415a993a
Author: Sylvain Defresne <sdefresne@google.com>
Date: Fri Sep 15 19:00:43 2017
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0743b8ef6f8c5a1089407f6f3121a3efa84911e5

commit 0743b8ef6f8c5a1089407f6f3121a3efa84911e5
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Dec 29 09:32:43 2017

Remove usage of weak_nsobject in ios/.

Removes all use of weak_nsobject because __weak can now be used instead.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4d5f40aaec01489d3e8f2dedc3e7b1a2d2a71f44
Reviewed-on: https://chromium-review.googlesource.com/845626
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526366}
[modify] https://crrev.com/0743b8ef6f8c5a1089407f6f3121a3efa84911e5/ios/web_view/internal/signin/ios_web_view_signin_client.h
[modify] https://crrev.com/0743b8ef6f8c5a1089407f6f3121a3efa84911e5/ios/web_view/internal/signin/ios_web_view_signin_client.mm
[modify] https://crrev.com/0743b8ef6f8c5a1089407f6f3121a3efa84911e5/ios/web_view/internal/signin/web_view_profile_oauth2_token_service_ios_provider_impl.h
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3984619b43d1c3570bc658f12cff48286ab3fb94

commit 3984619b43d1c3570bc658f12cff48286ab3fb94
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Dec 29 19:49:12 2017

Remove usage of scoped_nsobject from implementation files [2/3].

Removes usage of scoped_nsobject and replaces with strong variables.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaa625d54f507fac7657d2c7aed4f05adc2f1c009
Reviewed-on: https://chromium-review.googlesource.com/846765
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526380}
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/chrome/browser/voice/text_to_speech_listener_unittest.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/chrome/browser/voice/voice_search_url_rewriter.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/chrome/common/app_group/app_group_metrics_client.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/chrome/test/block_cleanup_test.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/chrome/test/earl_grey/chrome_earl_grey.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/net/crn_http_protocol_handler.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/net/crn_http_protocol_handler_proxy_with_client_thread.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/net/crn_http_url_response.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/net/protocol_handler_util.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/testing/ocmock_complex_type_helper.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/web/navigation/crw_session_controller.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/web/navigation/history_state_operations_inttest.mm
[modify] https://crrev.com/3984619b43d1c3570bc658f12cff48286ab3fb94/ios/web/net/crw_ssl_status_updater.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2

commit b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Dec 29 19:49:20 2017

Remove usage of scoped_nsobject from implementation files [1/3].

Removes usage of scoped_nsobject and replaces with strong variables.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib4296ff36578acbf3b4636154dbf3ad6bb49d8dd
Reviewed-on: https://chromium-review.googlesource.com/846799
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526381}
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/crash_report/crash_report_background_uploader.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/crash_report/crash_report_multi_parameter.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/device_sharing/device_sharing_manager.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/geolocation/location_manager_unittest.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/geolocation/omnibox_geolocation_local_state_unittest.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/net/retryable_url_fetcher_unittest.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/share_extension/share_extension_service.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/autofill/autofill_edit_accessory_view.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/context_menu/context_menu_coordinator.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/dialogs/dialog_presenter.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/keyboard/UIKeyCommand+Chrome.h
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/keyboard/UIKeyCommand+ChromeTest.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/network_activity_indicator_manager.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/page_info/page_info_view_controller.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/safe_mode/safe_mode_coordinator_unittest.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm
[modify] https://crrev.com/b9f800a0199a9ce58f866e5a42ac1f18cc19bcf2/ios/chrome/browser/ui/voice/text_to_speech_player.mm
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9cecf5229e3d68b7a42a59d147172a86e977550

commit e9cecf5229e3d68b7a42a59d147172a86e977550
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Dec 29 19:51:30 2017

Remove usage of scoped_nsobject from implementation files [3/3].

Removes usage of scoped_nsobject and replaces with strong variables.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife440b162d9b6a153ab9d8dc243aa2f6a5b3b135
Reviewed-on: https://chromium-review.googlesource.com/846742
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526385}
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/public/crw_session_certificate_policy_cache_storage_unittest.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/public/test/http_server_inttest.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/public/user_agent.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/shell/app_delegate.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/shell/view_controller.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/error_translation_util.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/js/crw_js_injection_manager.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/js/crw_js_injection_receiver.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/js/crw_js_post_request_loader.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/js/crw_js_window_id_manager.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/session_certificate_policy_cache_storage_builder_unittest.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/ui/crw_generic_content_view.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/ui/crw_web_view_proxy_impl.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/webui/crw_web_ui_manager.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web/webui/crw_web_ui_page_builder.mm
[modify] https://crrev.com/e9cecf5229e3d68b7a42a59d147172a86e977550/ios/web_view/internal/translate/web_view_translate_client.mm
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d

commit d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Dec 29 19:53:36 2017

Remove usage of scoped_nsobject in ios/chrome/browser.

Removes almost all usage of scoped_nsobject in ios/chrome.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I693be4f1a9bdb1ebad1e5b9c20a913999b0e0823
Reviewed-on: https://chromium-review.googlesource.com/846801
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526388}
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/autofill/form_suggestion_label.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/find_in_page/find_tab_helper.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/find_in_page/find_tab_helper.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/infobars/infobar.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/infobars/infobar.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/infobars/infobar_container_ios.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/infobars/infobar_container_ios.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/payments/ios_payment_instrument.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/authentication_service.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/authentication_service.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/authentication_service_fake.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/authentication_service_unittest.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/browser_state_data_remover.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/browser_state_data_remover.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/signin/gaia_auth_fetcher_ios_private.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/tabs/legacy_tab_helper.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/tabs/legacy_tab_helper.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/test/perf_test_with_bvc_ios.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/collection_view/collection_view_controller_test.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/collection_view/collection_view_controller_test.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/dialogs/java_script_dialog_presenter_impl.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/external_file_controller.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/omnibox/truncating_attributed_label.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/open_in_controller.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/page_info/page_info_view_controller.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/payments/full_card_requester.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/settings/passphrase_collection_view_controller_test.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/settings/passphrase_collection_view_controller_test.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/settings/sync_utils/sync_error_infobar_delegate.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/stack_view/card_stack_layout_manager.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/stack_view/card_stack_layout_manager_unittest.mm
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/tabs/tab_view.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.h
[modify] https://crrev.com/d5c2dd7bc9faff3dc20f3f8effa7a9daa4449a6d/ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.mm
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1856a3ddb3b43662ba637fd007e841f8225f583

commit d1856a3ddb3b43662ba637fd007e841f8225f583
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jan 03 13:17:54 2018

Remove most usage of scoped_nsobject in ios/.

Removes most usage of scoped_nsobject in ios/, except

- ios/web/net/request_tracker_impl.{h|mm}
- ios/web/public

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I02cff4e1786f7405d055faf1ca7f8b1cc40ac417
Reviewed-on: https://chromium-review.googlesource.com/846803
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526673}
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/chrome/app/spotlight/base_spotlight_manager.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/net/cookies/cookie_store_ios.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/net/crn_http_protocol_handler.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/net/crn_http_protocol_handler.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/public/provider/chrome/browser/signin/test_signin_resources_provider.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/interstitials/html_web_interstitial_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/interstitials/html_web_interstitial_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/interstitials/native_web_interstitial_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/interstitials/native_web_interstitial_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/legacy_navigation_manager_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/legacy_navigation_manager_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/navigation_item_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/navigation_item_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/navigation_item_storage_builder.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/serializable_user_data_manager_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/serializable_user_data_manager_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/navigation/wk_based_navigation_manager_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/net/cookie_notification_bridge.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/net/cookie_notification_bridge.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/net/request_tracker_factory_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/net/request_tracker_factory_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/navigation_context_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/navigation_context_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/session_certificate_policy_cache_impl.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/session_certificate_policy_cache_impl.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/ui/wk_back_forward_list_item_holder.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/ui/wk_web_view_configuration_provider.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web_view/internal/web_view_early_page_script_provider.h
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web_view/internal/web_view_early_page_script_provider.mm
[modify] https://crrev.com/d1856a3ddb3b43662ba637fd007e841f8225f583/ios/web_view/test/web_view_int_test.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f482af24fd594530dbb5f85fce1aa616ee5995f5

commit f482af24fd594530dbb5f85fce1aa616ee5995f5
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jan 03 16:32:16 2018

Removes more usage of scoped_nsobject.

Removes usage of scoped_nsobject in ios/web/public.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icec9644b72efd0d57db00c4ed106575d5de59c9f
Reviewed-on: https://chromium-review.googlesource.com/846804
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526714}
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/chrome/browser/ui/context_menu/context_menu_coordinator_unittest.mm
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/chrome/browser/ui/history/history_collection_view_controller.mm
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/web/public/test/web_js_test.h
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/web/public/web_state/context_menu_params.h
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/web/web_state/context_menu_params_utils.mm
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/web/web_state/context_menu_params_utils_unittest.mm
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/web/web_state/ui/crw_context_menu_controller.mm
[modify] https://crrev.com/f482af24fd594530dbb5f85fce1aa616ee5995f5/ios/web/web_state/web_state_delegate_bridge_unittest.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5270651f4bebd6d4abb492610f0c634dcbd1f178

commit 5270651f4bebd6d4abb492610f0c634dcbd1f178
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jan 03 18:14:45 2018

Remove more usage of scoped_nsobject.

Removes almost all usage of scoped_nsobject in ios/.

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ide8fc8476e2dccaa91ba2311cdf5bb06b91d3779
Reviewed-on: https://chromium-review.googlesource.com/846805
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526742}
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/chrome/browser/tabs/tab_model_unittest.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/navigation/navigation_manager_impl.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/public/navigation_manager.h
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/5270651f4bebd6d4abb492610f0c634dcbd1f178/ios/web_view/internal/cwv_web_view.mm
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01bd9a3b3a40f2444087920f62a64a504c4fb7bd

commit 01bd9a3b3a40f2444087920f62a64a504c4fb7bd
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Jan 04 13:03:31 2018

Replace temporary unsafe_unretained with weak.

Now that everything in ios/ is built with ARC, it's possible to use
__weak everywhere instead of unsafe_unretained, except for where the
API dictates otherwise, especially:
1. countByEnumeratingWithState:objects:count:
2. getArgument:atIndex:

Bug:  717540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I700f0ce62f7fd5801c4ed2e9bbfed81065b0bf0f
Reviewed-on: https://chromium-review.googlesource.com/845686
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526968}
[modify] https://crrev.com/01bd9a3b3a40f2444087920f62a64a504c4fb7bd/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h
[modify] https://crrev.com/01bd9a3b3a40f2444087920f62a64a504c4fb7bd/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.h
[modify] https://crrev.com/01bd9a3b3a40f2444087920f62a64a504c4fb7bd/ios/chrome/browser/ui/tab_switcher/tab_switcher_view.h
[modify] https://crrev.com/01bd9a3b3a40f2444087920f62a64a504c4fb7bd/ios/chrome/browser/ui/util/label_link_controller.mm

Comment 14 by stkhapugin@chromium.org, Feb 23 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment