Issue metadata
Sign in to add a comment
|
Refactor storage.indexeddb_* benchmarks |
||||||||||||||||||||||
Issue descriptionThese benchmarks doesn't fit into any of our existing harnesses. So we need to either remove them or refactor them. I think it would be straight forward to port them to blink_perf harness. Assigned to cmumford@ for answering: "should we remove these benchmarks or keep & refactor them?"
,
May 2 2017
Yes we would like them, with the same configuration. How do we migrate to your supported test harness?
,
May 2 2017
There are two benchmarks here: 1) storage.indexeddb_endure 2) storage.indexeddb_endure_tracing 2) is essentially the same as one, except that it output tracing metrics during the test. (1) is just about output the JS data in automation.getResults() I think this fits nicely into blink_perf harness. We can think about how to migrate (1) to webkit/PerformanceTests/ first, then (2) will follows easily.
,
May 2 2017
The automation.getResults() is actually pretty noisy I think - the 2) test is the more important, we have good alerts here.
,
May 2 2017
Ah, good to know. blink_perf tracing should allows us to get both js based results & tracing based in one run.
,
May 3 2017
,
Jul 18 2017
,
Aug 31 2017
Ping. If you are not working on this, I will remove the benchmarks next week. Reenabling them need to be done in new blink_perf framework.
,
Sep 5 2017
Not working on this right now, but it should be soon. Kristi just migrated the blob ones and might migrate these ones if there is time.
,
Sep 5 2017
I will give this bug 3 more weeks. If there is still no activity by that point, I will turn off the current benchmarks.
,
Sep 26 2017
The NextAction date has arrived: 2017-09-26
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fd5cf35795ddb2c8282c463dbf1a2f858040216 commit 0fd5cf35795ddb2c8282c463dbf1a2f858040216 Author: Ned Nguyen <nednguyen@google.com> Date: Tue Sep 26 16:15:58 2017 Remove storage.indexeddb_* benchmarks THis benchmark doesn't use our supported harnesses Bug: 717539 Change-Id: Id90301a5d8632d81edab30d815fb15479b7d2fe2 Reviewed-on: https://chromium-review.googlesource.com/684416 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504385} [modify] https://crrev.com/0fd5cf35795ddb2c8282c463dbf1a2f858040216/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/0fd5cf35795ddb2c8282c463dbf1a2f858040216/testing/buildbot/chromium.perf.json [modify] https://crrev.com/0fd5cf35795ddb2c8282c463dbf1a2f858040216/tools/perf/benchmark.csv [modify] https://crrev.com/0fd5cf35795ddb2c8282c463dbf1a2f858040216/tools/perf/benchmarks/benchmark_smoke_unittest.py [delete] https://crrev.com/2824ef26127320c50ce1f64d2b0f02233ecfabb4/tools/perf/benchmarks/indexeddb_perf.py [delete] https://crrev.com/2824ef26127320c50ce1f64d2b0f02233ecfabb4/tools/perf/page_sets/indexeddb_endure_page.py
,
Oct 17 2017
The benchmarks were removed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jsb...@chromium.org
, May 2 2017Owner: dmu...@chromium.org