Remove or refactor repaint benchmarks into our supported harnesses |
|||||
Issue descriptionThese repaint.* benchmarks doesn't fit into our supported harness, so we should remove them (from the perf waterfall) or refactor them. I think this probably also fit into blink_perf harness. *For repaint cluster telemetry benchmark, we can move it to tools/perf/contrib directory (tracked in issue 715704 ) Notes that all of these benchmarks have been failing for a while. (See https://cs.chromium.org/chromium/src/tools/perf/benchmarks/repaint.py?rcl=68557831bd0eefa24608e16f7018dc89059a9a09&l=47) Assign to Walter for answering: "should we remove these benchmarks or try to refactor & fix them?"
,
May 9 2017
Ping Walter: we are trying to clean up our benchmarks this quarter.
,
May 9 2017
I think these are old benchmarks, no longer used, and can be removed. I want to checkpoint with pdr@ and chrishtr@ to confirm before final confirmation. I have not personally looked at them, and they look to be from 2014/2015 or earlier, which predates my time on the team.
,
May 9 2017
Is this for RepaintKeyMobileSites and RepaintGpuRasterizationKeyMobileSites? If so, I think it is okay to remove them.
,
May 9 2017
#4: correct. RepaintCT will be moved to tools/perf/contrib (see issue 715704 )
,
May 11 2017
Issue 499320 has been merged into this issue.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ac1e972f92e44597cf8c9a0473fa2fc7f50655e commit 9ac1e972f92e44597cf8c9a0473fa2fc7f50655e Author: wkorman <wkorman@chromium.org> Date: Thu May 11 20:29:30 2017 Remove obsolete repaint benchmarks. BUG= 717538 , 715704 Review-Url: https://codereview.chromium.org/2874043003 Cr-Commit-Position: refs/heads/master@{#471057} [modify] https://crrev.com/9ac1e972f92e44597cf8c9a0473fa2fc7f50655e/tools/perf/benchmark.csv [modify] https://crrev.com/9ac1e972f92e44597cf8c9a0473fa2fc7f50655e/tools/perf/benchmarks/repaint.py [modify] https://crrev.com/9ac1e972f92e44597cf8c9a0473fa2fc7f50655e/tools/perf/core/benchmark_sharding_map.json [delete] https://crrev.com/e41b5ce8a877875575ad0c370bd4bdc8593113b2/tools/perf/page_sets/data/key_mobile_sites_repaint.json [delete] https://crrev.com/e41b5ce8a877875575ad0c370bd4bdc8593113b2/tools/perf/page_sets/key_mobile_sites_repaint.py
,
May 12 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by benhenry@chromium.org
, May 3 2017