Wait more patiently for PasswordStore results if needed |
||
Issue descriptionAfter bug 621355 is completed, PasswordManager.ProvisionalSaveFailure histogram's MATCHING_NOT_COMPLETE value should drop to 0. As a further step to avoid even the tiniest flake, we should keep the PasswordManager::provisional_save_manager_ alive until both its FormFetcher is no longer WAITING, and the forms of the landing page have been rendered. Only decide then whether to offer saving or give up.
,
Jan 28 2018
Strange! The XML definition is https://chromium.googlesource.com/chromium/src/+/d3ff47852e2face5ffe1d8f3464329cb157ebff7/tools/metrics/histograms/histograms.xml#60856 and seems valid. It also seems to be used at https://chromium.googlesource.com/chromium/src/+/d3ff47852e2face5ffe1d8f3464329cb157ebff7/components/password_manager/core/browser/password_manager_metrics_recorder.cc#49. Yet, I cannot see it in UMA dashboard. Perhaps asvitkine@ could advise us on how to figure out what's wrong? |
||
►
Sign in to add a comment |
||
Comment 1 by kolos@chromium.org
, Jan 26 2018