Remove or refactor gpu_times.* benchmarks to use supported harness |
|||
Issue descriptionThese gpu_times.* benchmarks do not fit into any of our supported harnesses. They have been failing on all platform for a long time, and there is no clear ownership (See https://cs.chromium.org/chromium/src/tools/perf/benchmarks/gpu_times.py?rcl=8569024f3f1ef296d6614c9482b9de6ed14b3ced&l=32). Victor: can we just remove them? If not, we probably need to think how this can fit to our supported harness, e.g: smoothness/blink_perf/power (thread_times)
,
May 9 2017
Hmm, perhaps we should remove them. I'll take a look. Regressions here should be covered by power metrics.
,
May 9 2017
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3edd0dad3fd5511ded2a49ce0ce2642718f8801c commit 3edd0dad3fd5511ded2a49ce0ce2642718f8801c Author: vmiura <vmiura@chromium.org> Date: Wed May 17 03:53:38 2017 Remove gpu_times.* performance benchmarks. R=nednguyen@google.com BUG= 717530 Review-Url: https://codereview.chromium.org/2885683002 Cr-Commit-Position: refs/heads/master@{#472313} [modify] https://crrev.com/3edd0dad3fd5511ded2a49ce0ce2642718f8801c/tools/perf/benchmark.csv [delete] https://crrev.com/d3469945247f829dba6050907f8555ff7afa5cdf/tools/perf/benchmarks/gpu_times.py [modify] https://crrev.com/3edd0dad3fd5511ded2a49ce0ce2642718f8801c/tools/perf/core/benchmark_sharding_map.json [modify] https://crrev.com/3edd0dad3fd5511ded2a49ce0ce2642718f8801c/tools/perf/unowned_benchmarks.txt
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c8192df7c59edb4b33963f94ee538000d36302d commit 0c8192df7c59edb4b33963f94ee538000d36302d Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Wed May 17 13:23:55 2017 Roll src/third_party/catapult/ dab2aa44c..74f540562 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/dab2aa44c6cd..74f54056233e $ git log dab2aa44c..74f540562 --date=short --no-merges --format='%ad %ae %s' 2017-05-17 nednguyen Remove gpu_timeline metric Created with: roll-dep src/third_party/catapult BUG= 717530 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7c6a3a43a0fa8c2fcd623d65ae812da961d60047 Reviewed-on: https://chromium-review.googlesource.com/507247 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#472438} [modify] https://crrev.com/0c8192df7c59edb4b33963f94ee538000d36302d/DEPS
,
May 17 2017
,
May 17 2017
Great thanks to Victor for your quick response on this bug! |
|||
►
Sign in to add a comment |
|||
Comment 1 by benhenry@chromium.org
, May 3 2017