New issue
Advanced search Search tips

Issue 717515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-08-30
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 575762


Participants' hotlists:
dmurph-future-tasks


Sign in to add a comment

Refactor blob_storage.* benchmarks to use blink_perf tracing

Project Member Reported by nedngu...@google.com, May 2 2017

Issue description

blob_storage.* benchmarks doesn't use our supported benchmark harnesses. So we need to either:
1) Remove them
2) Migrate them to blink_perf
3) Move them to tools/perf/contrib/ directory. This means the benchmark will only be runnable locally & through trybot & not scheduled on perf waterfall.

 
Yes we would like them, with the same configuration. How do we migrate to your supported test harness?
I think this can be refactored to a blink_perf tests in https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/?q=PerformanceTest&dr

Recently, I added some support for tracing to blink_perf harnesses ( issue 701059 ), which I think should makes it possible to support this. 

For starting point, you can try to write blink_perf tests that output tracing similar to ones in https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/TestData/append-child-measure-time.html ?

To run the test there with tracing, you can add a blink_perf benchmarks that point to TestData directory (see line 286 in https://codereview.chromium.org/2819343002/diff/230001/tools/perf/benchmarks/blink_perf.py)

*Since blob_storage events are collected from browser process, I probably need to update my code to allows users specify events across all Chrome processes :-)
Summary: Refactor blob_storage.* benchmarks to use blink_perf tracing (was: Remove blob_storage.* benchmarks or migrate them to blink_perf)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 18 2017

Labels: Hotlist-Google
Any movement on this bug?

Comment 6 by dmu...@chromium.org, Aug 11 2017

I plan on doing this soon :)
Components: Speed>Benchmarks
NextAction: 2017-08-30
Thanks! You probably know blink_perf very well know :-)

Comment 8 by dmu...@chromium.org, Aug 21 2017

Owner: kristip...@chromium.org
Assigning to Kristi.

More infomation:


Here is information about telemetry:
https://catapult.gsrc.io/tracing/README.md
https://www.chromium.org/developers/telemetry/run_locally
https://docs.google.com/document/d/1ni2MIeVnlH4bTj4yvEDMVNxgL73PqK_O9_NUm3NW3BA/edit

This is the docs perf test that I added recently:
https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/OWPStorage/idb-load-docs.html


The benchmark should run if you build chrome or content_shell, then:

tools/perf/run_benchmark OWPStorage

and then there's probably a way to select the sub-test.



I'm imagining you'll have a runner that runs two tests, a BuildAllThenRead and a BuildAndReadImmedately. Each could be a different runner iframe in resources/. You just need to have it accept URL parameters to specify the size & number of blobs (and if there is neither then you can just have buttons for testing).
Cc: dmu...@chromium.org
The NextAction date has arrived: 2017-08-30
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81a84d3780e34e33b668aaf3cf4129f350562d6

commit f81a84d3780e34e33b668aaf3cf4129f350562d6
Author: kristipark <kristipark@chromium.org>
Date: Wed Aug 30 17:44:07 2017

[Benchmarks] Refactored blob storage benchmarks to use blink_perf tracing

Bug:  717515 
Change-Id: I72741db39484d1349fa315009b0cadf58060cd22
Reviewed-on: https://chromium-review.googlesource.com/636037
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498529}
[modify] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/README.md
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-parallel.html
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-all-then-read-serially.html
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/blob-build-and-read-immediately.html
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-build-all-then-read-parallel-runner.html
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-build-all-then-read-serially-runner.html
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-build-and-read-immediately-runner.html
[add] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/resources/blob-shared.js
[modify] https://crrev.com/f81a84d3780e34e33b668aaf3cf4129f350562d6/third_party/WebKit/PerformanceTests/OWPStorage/resources/shared.js

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
This bug shouldn't be considered fixed until we removed the legacy blob storage benchmarks & their related code (https://cs.chromium.org/chromium/src/tools/perf/benchmarks/blob_storage.py?rcl=f81a84d3780e34e33b668aaf3cf4129f350562d6&l=18)
Sorry about that, change to remove started here
https://chromium-review.googlesource.com/c/chromium/src/+/644141
Status: Fixed (was: Started)
Can you also remove the legacy blob_storage code (blob_timeline*) in https://github.com/catapult-project/catapult/tree/master/telemetry/telemetry/web_perf/metrics? 
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d33a9557ccd125e36a6aa3b269a6f93424256eb0

commit d33a9557ccd125e36a6aa3b269a6f93424256eb0
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Sep 02 02:20:04 2017

Roll src/third_party/catapult/ 017fd5cf4..e29053eb7 (11 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/017fd5cf4ccb..e29053eb7dfc

$ git log 017fd5cf4..e29053eb7 --date=short --no-merges --format='%ad %ae %s'
2017-09-01 dtu [pinpoint] Handle missing chartjson files.
2017-09-01 simonhatch Pinpoint - Update job dialog with latest names + tir_label.
2017-09-01 tiborg [vr] Add metric to measure frame cycle times
2017-09-01 charliea Move the benchmark health report's deps into a requirements.txt file
2017-09-01 kristipark [Telemetry] Removed legacy blob storage metrics
2017-09-01 kraynov Android systrace: Plot used memory from /proc/meminfo.
2017-09-01 benjhayden Clean up histogram-set-json-format.md
2017-09-01 benjhayden Serialize traces when --output-format=html.
2017-09-01 charliea Upload a new version of the BattOr firmware
2017-09-01 charliea Make BattOrWrapper StopTracing check for 'Done.'
2017-09-01 djordje.golubovic.imgtec Update the update_v8 script to support MIPS

Created with:
  roll-dep src/third_party/catapult
BUG= 726906 , 717515 , 757508 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I22caf15b3a034b5b0779e40dd967f468e401c892
Reviewed-on: https://chromium-review.googlesource.com/647655
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499376}
[modify] https://crrev.com/d33a9557ccd125e36a6aa3b269a6f93424256eb0/DEPS

Sign in to add a comment