depot_tools presubmit should support running presubmit continuously |
||||||
Issue descriptionV8 historically runs a continuous presubmit bot to signal presubmit breakages on the waterfall (e.g. caused by bypassing presubmit). For this, V8 uses its own separate presubmit script, which is hard to maintain: https://cs.chromium.org/chromium/src/v8/tools/presubmit.py The depot_tools presubmit API should offer a third hook besides upload and commit hooks that allows running PRESUBMIT.py scripts on a range of changes instead of a CL.
,
May 10 2017
Yeah, this is a great idea. I mean, I really dislike PRESUBMIT, and I really dislike its API, and I think that we should be replacing it with Tricium (which already supports running on arbitrary commits, not just diffs) instead of giving it even more features. But yeah, this makes a lot of sense, and I totally support doing it if I or someone else has some free cycles in the near future.
,
May 10 2017
,
May 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 14 2018
This would still be good. If somebody had the time...
,
May 14 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kjellander@chromium.org
, May 10 2017