New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717501 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task

Blocking:
issue 662501



Sign in to add a comment

Add remora app to accessibilityPrivate users

Project Member Reported by cederberg@google.com, May 2 2017

Issue description

Please whitelist the remora/hotrod app ids to use the accessibilityPrivate API.

This was done for the virtualKeyboardPrivate api here: https://chromium.googlesource.com/chromium/src/+/88a46377ec04d4ad9786b4f367c92828629d8784%5E%21/#F0

"E703483CEF33DEC18B4B6DD84B5C776FB9182BDB",  // Stable external remora app
"A3BC37E2148AC4E99BE4B16AF9D42DD1E592BBBE",  // Beta external remora app
"1C93BD3CF875F4A73C0B2A163BB8FBDA8B8B3D80",  // Alpha external remora app
"307E96539209F95A1A8740C713E6998A73657D96",  // Dev external remora app
"4F25792AF1AA7483936DE29C07806F203C7170A0",  // Stable internal remora app
"BD8781D757D830FC2E85470A1B6E8A718B7EE0D9",  // Beta internal remora app
"4AC2B6C63C6480D150DFDA13E4A5956EB1D0DDBB",  // Alpha external remora app
"81986D4F846CEDDDB962643FA501D1780DD441BB"   // Dev external remora` app
 
Can you add some details on why this needs to be done?  We don't like to whitelist apps if we can help it.
Cc: rdevlin....@chromium.org
We need a way to toggle spoken feedback on a touch-only device. Originally we were going to do this natively but we decided to instead signal CFM when we detect a two-finger hold gesture and then let them add their own UI / feedback and toggle spoken feedback directly.

I added a new private API for them in accessibilityPrivate.

They're already whitelisted for several other private APIs so I was hoping this would make sense.

rdevlin, do you need additional information, or can we get this in?
Cc: jawag@chromium.org

Comment 6 by jawag@chromium.org, May 8 2017

Cc: lazyboy@chromium.org
After consulting with +lazyboy@, this seems reasonable to me. I don't have any objections. 

@rdevlin, please shout if you have any concerns once you're back in the office.
Do we need *all* these different IDs?  Feature whitelists are cheap-ish, but not free.  Additionally, is there any way we can further limit the scope of this?  If the app only needs one API method, can we whitelist them for just that method?  If it should only be used from e.g. kiosk mode, we can whitelist them for just those sessions.
I know very little about how this whitelisting works, but what is needed is

- the two listeners chrome.accessibilityPrivate.onTwoFingerTouchStart and chrome.accessibilityPrivate.onTwoFingerTouchStop
- in kiosk mode

We need all the app ids because of the release process we have in place, so sadly we can't prune that list.

In other words, both limiting the methods and the mode like you suggested seems like a perfectly reasonable solution.

Can you or lazyboy@ throw together such a CL, or give directions to Felix how to do it? It would be much appreciated.
Cool!  So we should be able to limit the scope significantly.  Unfortunately since we need two events, this will mean *more* features, but the increased security from not exposing more features is probably worthwhile.

Changing the whitelisting should be pretty straightforward, but I'm still essentially OOO this week.  lazyboy@, mind taking the review?  (I've added you to it.)
@Comment 9, will do.
Status: Assigned (was: Untriaged)
Untriaged w/ owner -> assigned
Project Member

Comment 12 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf6be1dcf5f2fd0dd190742381d9dd52c0f3d26

commit ecf6be1dcf5f2fd0dd190742381d9dd52c0f3d26
Author: felixe <felixe@chromium.org>
Date: Mon May 22 21:18:40 2017

Whitelist accessibilityPrivate APIs

BUG= 717501 

Review-Url: https://codereview.chromium.org/2857143002
Cr-Commit-Position: refs/heads/master@{#473700}

[modify] https://crrev.com/ecf6be1dcf5f2fd0dd190742381d9dd52c0f3d26/chrome/common/extensions/api/_api_features.json

Status: Fixed (was: Assigned)
Labels: Merge-Request-60
Project Member

Comment 15 by sheriffbot@chromium.org, May 23 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We don't branch M60 until 2017-05-25.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
We haven't branched M60 yet, your change landed in time.

Did you mean to merge to 59?

Oh, sorry, was not paying attention there. No merging needed.
Labels: -M-59 -Merge-Review-60 M-60

Comment 19 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment