New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717488 link

Starred by 1 user
Status: Fixed
Owner:
█ kjellander@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ perkj@chromium.org
█ deadbeef@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Enhancement


Previous locations:
webrtc:7550


Sign in to add a comment

Run jingle_unittests for desktop at chromium.webrtc[.fyi] bots.

Reported by perkj@webrtc.org, May 2 2017 
Can we run jingle_unittests as part of Chrome FYI waterfall?


This target failed when doing a Chrome roll. 
https://codereview.chromium.org/2854813002/
 
jingle_unittests (with patch) jingle_unittests (with patch)
Run on OS: 'Ubuntu-14.04'
swarming pending 45s
failures:
XmppConnectionTest.ConnectThenError
XmppConnectionTest.RaisedError
XmppConnectionTest.FailureAfterPreAuth
XmppConnectionTest.PreAuthFailure
XmppConnectionTest.ImmediateFailure

Comment 1 by kjellander@chromium.org, May 2 2017

Project: chromium
Moved issue webrtc:7550 to now be  issue chromium:717488 .

Comment 2 by kjellander@chromium.org, May 2 2017

Cc: -deadbeef@webrtc.org perkj@chromium.org deadbeef@chromium.org

Comment 3 by kjellander@chromium.org, May 2 2017

Components:
Owner: kjellander@chromium.org
Summary: Run jingle_unittests for desktop at chromium.webrtc[.fyi] bots. (was: jingle_unittests not run as part of Chrome FYI?)
Per: What about Android?
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19608f5d0409390bc7e25da2baf208b517bba3b3

commit 19608f5d0409390bc7e25da2baf208b517bba3b3
Author: kjellander <kjellander@chromium.org>
Date: Tue May 02 13:52:23 2017

Add jingle_unittests to Chromium WebRTC bots.

Also remove tests we don't run from being built:
gpu_ipc_service_unittests
media_unittests
midi_unittests

BUG= 717488 
NOTRY=True

Review-Url: https://codereview.chromium.org/2854823002
Cr-Commit-Position: refs/heads/master@{#468622}

[modify] https://crrev.com/19608f5d0409390bc7e25da2baf208b517bba3b3/testing/buildbot/chromium.webrtc.json
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9d72bb9279af4091921a00ca0e6cb59452f0c639

commit 9d72bb9279af4091921a00ca0e6cb59452f0c639
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Tue May 02 14:02:26 2017

WebRTC: Add jingle_unittests to desktop bots.

This depends on https://codereview.chromium.org/2854823002/
being landed first.

BUG= 717488 

Change-Id: I33d1f0d6c991ce673164b6c02662cc9df4e41da4
Reviewed-on: https://chromium-review.googlesource.com/493228
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win8_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win10_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win10_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Builder.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Linux_Builder.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win7_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win_Builder.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Win7_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Builder.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Linux_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win8_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_Mac_Tester.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Win_Builder.json
[modify] https://crrev.com/9d72bb9279af4091921a00ca0e6cb59452f0c639/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_Builder.json

Comment 6 by kjellander@chromium.org, May 2 2017

Status: Fixed (was: Assigned)
Assuming Android is not important (doesn't run on any of the main bots), I'm closing this as fixed.
►

Sign in to add a comment