New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717483 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
No longer actively working on Chrom...
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Speak answer back switch UI is not disabled when unsupported language is selected.

Project Member Reported by rakurati@chromium.org, May 2 2017

Issue description

App Version: 59.0.3071.30
iOS Version: 10.3.1, 10.2.1
Device: iPhone, iPad

Steps to reproduce:
1. Launch chrome.
2. Tap on Menu > Settings > Tap on voice search. 
3. Scroll the list down and tap on any language which does not support speak back (Say : Hrvatski)

Observed results:
Speak answer back switch UI is not disabled. 

Note 1: Speak answer back disable (turn off switch button) and repeat the same steps, at step 3 tap on any language that supports speak back notice speak answer back is not enabled.
Note 2: Works good if tap on language without scrolling the list down (please refer video).

Expected results:
Speak answer back switch button should be enabled for the supported languages and disabled for the languages which does not support.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Firefox/Safari: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes on 58
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on 59

Link to video/image:
Speak answers back disabled: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8bzZ4V3p1NWlPSkk/view?usp=sharing
Without scroll: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8QUVHSmFfT2FMMDA/view?usp=sharing

 

Comment 1 by sczs@chromium.org, May 3 2017

Cc: kkhorimoto@chromium.org sczs@chromium.org
Labels: M-60
Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)
Hi lpromero@ could you please take a quick look, I guess that switch is not observing any changes. 
Status: Started (was: Assigned)
The cell is modified, but not the underlying CollectionViewItem.
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/644d16e85e314eea64abdb2ebd30b11ed731f5c9

commit 644d16e85e314eea64abdb2ebd30b11ed731f5c9
Author: lpromero <lpromero@chromium.org>
Date: Thu May 04 16:03:15 2017

Update the Speak answers back switch item.

BUG= 717483 
R=sczs@chromium.org
TEST=See steps in bug.

Review-Url: https://codereview.chromium.org/2862583005
Cr-Commit-Position: refs/heads/master@{#469348}

[modify] https://crrev.com/644d16e85e314eea64abdb2ebd30b11ed731f5c9/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified the issue on the build 60.0.3094.0 canary tested on iPhone7+(10.3.1)
Speak answer back switch UI is disabled,works fine.

Sign in to add a comment