Non-Regression : Unnecessary Pause/Play option is seen even for one Image in slideshow of Gallery |
|||||||
Issue descriptionChrome Version: 59.0.3071.33/9460.20.0 dev-channel Daisy,Candy,Jerry ,Quawks and Minnie OS: Chrome What steps will reproduce the problem? 1.Sign in to user ->Download One Image 2.Now in Files App,Select Image and open it in Gallery -> Click on 'Slideshow' option 3.Now Observe Unnecessary Pause/Play option is seen even for one Image in slideshow (Please refer video and screenshot) Expected: Pause/Play option should not be seen for one Image in slideshow Actual: Instead Unnecessary Pause/Play option is seen even for one Image This is Non-Regression Issue as seen form M-57 @Yawano: Please confirm the Issue.
,
Oct 8
I am working towards a fix for this, so I will take ownership unless you all have someone else in mind. For reference : https://chromium-review.googlesource.com/c/chromium/src/+/1265822
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ed6beda453e6a8bb29aea298a9bf841e8434e5b commit 7ed6beda453e6a8bb29aea298a9bf841e8434e5b Author: Alexander Nohe <nohe@chromium.org> Date: Wed Oct 10 03:07:52 2018 Unnecessary play option for one image in slideshow Hiding the play / pause button in the slideshow when only one image is loaded. This is unnecessary since the one image will be loaded and there is nothing to pause or play. Initial Slideshow fix and tests Bug: 717482 Change-Id: Iba7f74d4237ac46405be5cc7cabfd92f7a177f00 Reviewed-on: https://chromium-review.googlesource.com/c/1265822 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#598195} [modify] https://crrev.com/7ed6beda453e6a8bb29aea298a9bf841e8434e5b/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/7ed6beda453e6a8bb29aea298a9bf841e8434e5b/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/7ed6beda453e6a8bb29aea298a9bf841e8434e5b/ui/file_manager/integration_tests/gallery/slideshow.js
,
Oct 10
,
Oct 12
,
Oct 13
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
,
Oct 17
Visible in Chrome Canary |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by weifangsun@chromium.org
, Jun 7 2018Labels: -Pri-2 -M-60 Pri-3
Owner: ----
Status: Available (was: Assigned)