New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717468 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression

Blocking:
issue 712446



Sign in to add a comment

[Site settings] Unwanted separator line is seen at 'All sites' page even if three dot menu is not available

Reported by sans...@etouch.net, May 2 2017

Issue description

Chrome Version: 60.0.3086.0 4159f36e93c398b9816b734a14e97220e83fc912-refs/heads/master@{#468266}-32/64 bit
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

Pre-condition: Enable Site settings with All sites and Site details from chrome://flags

Steps:
1. Launch Chrome and navigate to chrome://settings/content
2. Click on 'All sites' and observe

Actual: Unwanted separator line is seen at 'All sites' page even if three dot menu is not available

Expected: No such separator line should be seen at 'All sites' page even if three dot menu is not available

This is a regression issue broken in M-60, will soon update the bisect info

Good build: 60.0.3080.0
Bad build: 60.0.3081.6

 
Actual_Expected_result.png
88.7 KB View Download
Cc: sureshkumari@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3080.0 (Revision:466837).
Bad build: 60.0.3081.6 (Revision:467177).
CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/d77cac6405f78b26e5764bc23470ed088e209673..e8adf9ff14109d9a207c8abd143ca508085702b1

Review-Url: https://codereview.chromium.org/2832153004
dschuyler@ Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thanks.

Blocking: 712446
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: [Site settings] Unwanted separator line is seen at 'All sites' page even if three dot menu is not available (was: Regression: Unwanted separator line is seen at 'All sites' page even if three dot menu is not available)
Labels: -ReleaseBlock-Stable
I do not think "P3" bug is a 'Stable blocker', hence removing!

Project Member

Comment 4 by sheriffbot@chromium.org, May 10 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: patricia...@chromium.org
Status: Started (was: Untriaged)
This functionality appears to have been removed, but it is actually being restored in this patch: ccrev.com/c/1098577, so will attach this bug to that patch.
 Issue 715496  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2cac39f3c0aca0166794ea935e2244293aa9d4e

commit e2cac39f3c0aca0166794ea935e2244293aa9d4e
Author: Patti <patricialor@chromium.org>
Date: Wed Jun 20 05:55:37 2018

Settings: Content settings can now be reset for a group of origins in All Sites.

Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
menu allows the entire list of origins to have all their content settings reset
in one go. This will be preceded with a confirmation dialog.

Manual test - With #enable-site-settings turned on, change a content setting via
Page Info > Site settings on both https://permission.site and
http://permission.site. Navigate to chrome://settings/content/all and see that
both sites are listed under 'permission.site'. Verify there is an overflow menu
on this entry and that inside the overflow menu, there is a 'Reset permissions'
option. Clicking this should bring up a reset permission dialog and confirming
the dialog should remove this entry from All Sites.

Bug: 835712,  717468 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
Reviewed-on: https://chromium-review.googlesource.com/1098577
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568742}
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/e2cac39f3c0aca0166794ea935e2244293aa9d4e/chrome/test/data/webui/settings/site_entry_tests.js

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149bce0d01d769126d07181dd314f8090a21bbbe

commit 149bce0d01d769126d07181dd314f8090a21bbbe
Author: David Grogan <dgrogan@chromium.org>
Date: Wed Jun 20 20:58:00 2018

Revert "Settings: Content settings can now be reset for a group of origins in All Sites."

This reverts commit e2cac39f3c0aca0166794ea935e2244293aa9d4e.

Reason for revert:  https://crbug.com/854785  (CrSettingsSiteEntryTest.All failing on chromium.mac/Mac10.13 Tests (dbg))

TypeError: this.$.menu.getIfExists is not a function
    at HTMLElement.getOverflowMenu_ (chrome://settings/site_settings/site_entry.js:115:65)
    at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/site_entry_tests.js:136:25)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)

Original change's description:
> Settings: Content settings can now be reset for a group of origins in All Sites.
> 
> Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> menu allows the entire list of origins to have all their content settings reset
> in one go. This will be preceded with a confirmation dialog.
> 
> Manual test - With #enable-site-settings turned on, change a content setting via
> Page Info > Site settings on both https://permission.site and
> http://permission.site. Navigate to chrome://settings/content/all and see that
> both sites are listed under 'permission.site'. Verify there is an overflow menu
> on this entry and that inside the overflow menu, there is a 'Reset permissions'
> option. Clicking this should bring up a reset permission dialog and confirming
> the dialog should remove this entry from All Sites.
> 
> Bug: 835712,  717468 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> Reviewed-on: https://chromium-review.googlesource.com/1098577
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568742}

TBR=dschuyler@chromium.org,patricialor@chromium.org

Change-Id: I227ad85a38a66a6f571dab6aabfdfb5211580280
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835712,  717468 ,  854785  
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1108777
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569007}
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/app/settings_strings.grdp
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/149bce0d01d769126d07181dd314f8090a21bbbe/chrome/test/data/webui/settings/site_entry_tests.js

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/905d2540001fa7379d40426e4d37207f8f7fd1b1

commit 905d2540001fa7379d40426e4d37207f8f7fd1b1
Author: Patti <patricialor@chromium.org>
Date: Fri Jun 22 02:23:03 2018

Reland "Settings: Content settings can now be reset for a group of origins in All Sites."

This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e

Original change's description:
> Settings: Content settings can now be reset for a group of origins in All Sites.
> 
> Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> menu allows the entire list of origins to have all their content settings reset
> in one go. This will be preceded with a confirmation dialog.
> 
> Manual test - With #enable-site-settings turned on, change a content setting via
> Page Info > Site settings on both https://permission.site and
> http://permission.site. Navigate to chrome://settings/content/all and see that
> both sites are listed under 'permission.site'. Verify there is an overflow menu
> on this entry and that inside the overflow menu, there is a 'Reset permissions'
> option. Clicking this should bring up a reset permission dialog and confirming
> the dialog should remove this entry from All Sites.
> 
> Bug: 835712,  717468 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> Reviewed-on: https://chromium-review.googlesource.com/1098577
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568742}

Bug: 835712,  717468 
Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1109537
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569507}
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/app/settings_strings.grdp
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/905d2540001fa7379d40426e4d37207f8f7fd1b1/chrome/test/data/webui/settings/site_entry_tests.js

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe

commit b87c9121587d547162b56b5b0c8dfb8a6d1bebbe
Author: Peter Williamson <petewil@chromium.org>
Date: Fri Jun 22 21:31:09 2018

Revert "Reland "Settings: Content settings can now be reset for a group of origins in All Sites.""

This reverts commit 905d2540001fa7379d40426e4d37207f8f7fd1b1.

Reason for revert:
After landing this patch, CrSettingsSiteEntryTest started failing on Mac 10.13 (dbg) and Win 7(dbg), though it succeeds on other platforms.

Flakiness dashboard data here:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsSiteEntryTest.All

Picking this change as a likely culprit, so we can get the tree back to green everywhere.

https://crbug.com/855687
is tracking the issue.

Bug: 855687

Original change's description:
> Reland "Settings: Content settings can now be reset for a group of origins in All Sites."
> 
> This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e
> 
> Original change's description:
> > Settings: Content settings can now be reset for a group of origins in All Sites.
> > 
> > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> > menu allows the entire list of origins to have all their content settings reset
> > in one go. This will be preceded with a confirmation dialog.
> > 
> > Manual test - With #enable-site-settings turned on, change a content setting via
> > Page Info > Site settings on both https://permission.site and
> > http://permission.site. Navigate to chrome://settings/content/all and see that
> > both sites are listed under 'permission.site'. Verify there is an overflow menu
> > on this entry and that inside the overflow menu, there is a 'Reset permissions'
> > option. Clicking this should bring up a reset permission dialog and confirming
> > the dialog should remove this entry from All Sites.
> > 
> > Bug: 835712,  717468 
> > Cq-Include-Trybots: luci.chromium.try:closure_compilation
> > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> > Reviewed-on: https://chromium-review.googlesource.com/1098577
> > Commit-Queue: Patti <patricialor@chromium.org>
> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568742}
> 
> Bug: 835712,  717468 
> Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/1109537
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569507}

TBR=dschuyler@chromium.org,patricialor@chromium.org

Change-Id: I18f90cd22046b3d79efae2878aaca822b26bd828
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835712,  717468 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1112122
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569787}
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/b87c9121587d547162b56b5b0c8dfb8a6d1bebbe/chrome/test/data/webui/settings/site_entry_tests.js

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/112407912fd7aab9fb93add99131322a088559e4

commit 112407912fd7aab9fb93add99131322a088559e4
Author: Patti <patricialor@chromium.org>
Date: Tue Jun 26 02:50:55 2018

Reland "Settings: Content settings can now be reset for a group of origins in All Sites."

This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e

Original change's description:
> Settings: Content settings can now be reset for a group of origins in All Sites.
> 
> Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> menu allows the entire list of origins to have all their content settings reset
> in one go. This will be preceded with a confirmation dialog.
> 
> Manual test - With #enable-site-settings turned on, change a content setting via
> Page Info > Site settings on both https://permission.site and
> http://permission.site. Navigate to chrome://settings/content/all and see that
> both sites are listed under 'permission.site'. Verify there is an overflow menu
> on this entry and that inside the overflow menu, there is a 'Reset permissions'
> option. Clicking this should bring up a reset permission dialog and confirming
> the dialog should remove this entry from All Sites.
> 
> Bug: 835712,  717468 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> Reviewed-on: https://chromium-review.googlesource.com/1098577
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568742}

Bug: 835712,  717468 
Change-Id: I7825326b8fa133d54971180bfd37494b19c5e86c
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1113037
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570309}
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/112407912fd7aab9fb93add99131322a088559e4/chrome/test/data/webui/settings/site_entry_tests.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf209e50a20f7e7993decdc5f2947c755c26b31

commit 0cf209e50a20f7e7993decdc5f2947c755c26b31
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jun 26 16:41:49 2018

Revert "Reland "Settings: Content settings can now be reset for a group of origins in All Sites.""

This reverts commit 112407912fd7aab9fb93add99131322a088559e4.

Reason for revert: CrSettingsSiteDetailsTest.All consistently fails on linux-chromeos-dbg:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg

Original change's description:
> Reland "Settings: Content settings can now be reset for a group of origins in All Sites."
> 
> This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e
> 
> Original change's description:
> > Settings: Content settings can now be reset for a group of origins in All Sites.
> > 
> > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> > menu allows the entire list of origins to have all their content settings reset
> > in one go. This will be preceded with a confirmation dialog.
> > 
> > Manual test - With #enable-site-settings turned on, change a content setting via
> > Page Info > Site settings on both https://permission.site and
> > http://permission.site. Navigate to chrome://settings/content/all and see that
> > both sites are listed under 'permission.site'. Verify there is an overflow menu
> > on this entry and that inside the overflow menu, there is a 'Reset permissions'
> > option. Clicking this should bring up a reset permission dialog and confirming
> > the dialog should remove this entry from All Sites.
> > 
> > Bug: 835712,  717468 
> > Cq-Include-Trybots: luci.chromium.try:closure_compilation
> > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> > Reviewed-on: https://chromium-review.googlesource.com/1098577
> > Commit-Queue: Patti <patricialor@chromium.org>
> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568742}
> 
> Bug: 835712,  717468 
> Change-Id: I7825326b8fa133d54971180bfd37494b19c5e86c
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/1113037
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570309}

TBR=dschuyler@chromium.org,patricialor@chromium.org

Change-Id: Ia270a380442ebdd75014034a1ee980341a9b0f1f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835712,  717468 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1115179
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570427}
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/app/settings_strings.grdp
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/0cf209e50a20f7e7993decdc5f2947c755c26b31/chrome/test/data/webui/settings/site_entry_tests.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac19b43a9c276b0169dd263f7cd33f42785c21b

commit 3ac19b43a9c276b0169dd263f7cd33f42785c21b
Author: Patti <patricialor@chromium.org>
Date: Fri Jun 29 04:24:20 2018

Reland "Settings: Content settings can now be reset for a group of origins in All Sites."

This is a reland of e2cac39f3c0aca0166794ea935e2244293aa9d4e

Original change's description:
> Settings: Content settings can now be reset for a group of origins in All Sites.
>
> Add a three-dot / overflow menu to groups of origins in All Sites. This overflow
> menu allows the entire list of origins to have all their content settings reset
> in one go. This will be preceded with a confirmation dialog.
>
> Manual test - With #enable-site-settings turned on, change a content setting via
> Page Info > Site settings on both https://permission.site and
> http://permission.site. Navigate to chrome://settings/content/all and see that
> both sites are listed under 'permission.site'. Verify there is an overflow menu
> on this entry and that inside the overflow menu, there is a 'Reset permissions'
> option. Clicking this should bring up a reset permission dialog and confirming
> the dialog should remove this entry from All Sites.
>
> Bug: 835712,  717468 
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833
> Reviewed-on: https://chromium-review.googlesource.com/1098577
> Commit-Queue: Patti <patricialor@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568742}

TBR=stevenjb@chromium.org

Bug: 835712,  717468 
Change-Id: I88522c41a536e86e27b831358c61842d69f42d34
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1116318
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571386}
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/app/settings_strings.grdp
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_entry.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/3ac19b43a9c276b0169dd263f7cd33f42785c21b/chrome/test/data/webui/settings/site_entry_tests.js

Sign in to add a comment