New issue
Advanced search Search tips

Issue 717454 link

Starred by 1 user
Status: Fixed
Owner:
jdoerrie@chromium.org
Closed: May 2017
Cc:
dbeam@chromium.org
steve...@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD-Settings - Password not being shown for Android credentials

Project Member Reported by jdoerrie@chromium.org, May 2 2017 
Chrome Version: 60.0.3088.0 (Developer Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Have a saved Android credential
(2) Go to chrome://md-settings/passwords
(3) Click on the Android password's details
(4) Click on the 'Show password' button

What is the expected result?
Plain text password will be shown

What happens instead?
Password not shown

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by jdoerrie@chromium.org, May 2 2017

Status: Started (was: Assigned)
Fix is in http://crrev.com/2844963003.
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7

commit 2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu May 18 06:17:50 2017

Introduce extensions::CreateUrlCollectionFromForm

During the development of r466661 |GetHumanReadableOrigin| was replaced
by |CreateURLFromForm| in passwords_private_delegate_impl.cc to be to
handle Android credentials in an appropriate manner. However, there was
an undetected reliance on using |GetHumanReadableOrigin| in order to
display user passwords. Since the result of |CreateURLFromForm| is
slightly different, the frontend was unable to match origins when
displaying passwords.

This change addresses this issue by replacing other calls to
|GetHumanReadableOrigin| with |CreateUrlCollectionFromForm| restoring
consistency between results.

TBR=rdevlin.cronin@chromium.org
BUG= 717454 

Review-Url: https://codereview.chromium.org/2844963003
Cr-Commit-Position: refs/heads/master@{#472702}

[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
[add] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/api/passwords_private/passwords_private_utils.cc
[add] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/api/passwords_private/passwords_private_utils.h
[add] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/extensions/api/passwords_private/passwords_private_utils_unittest.cc
[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/browser/ui/passwords/password_ui_view.h
[modify] https://crrev.com/2d3f81e4a7d9839d5183dbabf17655fbbf0e5cb7/chrome/test/BUILD.gn

Comment 3 by jdoerrie@chromium.org, May 18 2017 

I landed the fix after verifying that it works for both regular and Android credentials. Unfortunately, I wasn't able to add extra browser test coverage. I'd be very happy if one of you folks could help me out with that.

Comment 4 by jdoerrie@chromium.org, May 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment