New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717417 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Logcat links not visible in Buildbot Web UI (only in swarming test logs)

Project Member Reported by kjellander@chromium.org, May 2 2017

Issue description

After https://codereview.chromium.org/2767833002 the logcats from Android test runs are uploaded to logdog storage (which is great!). Unfortunately the link to this location is only secretly printed in the test execution log, like this:

I  246.052s Main  Opening text logdog stream, unified_logcats
I  246.052s Main  Getting logdog client.
C  246.069s Main  Logcat: https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F35e04d2c1ccb6211%2F%2B%2Funified_logcats

It also looks weird to me that it's printed with the CRITICAL severity level, implying that this is some kind of fatal error happening.

This link should be easily accessible in the Buildbot Web UI, preferably along with all the other links presented for a test build, e.g.
stdout
swarming.summary
step_metadata
shard #0 isolated out
shard #0

From an example build: https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/168725

Having it buried in the log hides it from the average engineer, and it's inefficient to have to dig into the swarning output log to find this link when you want to view the logcat. Can we please fix this?

I'm setting this as Bug-Regression type, since such links were present in the past (pre-swarming days) as a separate build step.
 
Bonus: It would also be useful to write a logcat.log into the "isolated outputs" folder, since that's a location one would expect such a file to end up.
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e386fce74fe94b6de3645c64e2dbe81fc96e7690

commit e386fce74fe94b6de3645c64e2dbe81fc96e7690
Author: hzl <hzl@google.com>
Date: Thu May 04 01:07:31 2017

[Android] Enable test_results_presentation for gtests in chromium.android.json.

BUG= 717417 

Review-Url: https://codereview.chromium.org/2863523003
Cr-Commit-Position: refs/heads/master@{#469223}

[modify] https://crrev.com/e386fce74fe94b6de3645c64e2dbe81fc96e7690/testing/buildbot/chromium.android.json

Thanks for progress here. I see logcats are produced in the isolated output dir now, which is great. Will it be possible to also get a link to the logcat file in Web UI as well? I think that would be highly appreciated by developers.

I'm also trying to figure out why we don't see the logcats file in isolated output for our WebRTC bots. Are you able to see what we're missing? We're using the same chromium_tests.steps.GTestTest class as the other recipes here: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/steps.py?rcl=bb9f32300c4ca57516ee1b7c35579fe75553b6c6&l=153

Comment 4 by hzl@chromium.org, May 8 2017

Which bot do you want to add a link to the logcat file?
Cc: ehmaldonado@chromium.org
I'd like to have it for all our Android tester bots. E.g.:
* Nexus5X bots in: https://build.chromium.org/p/client.webrtc/waterfall
* Android testers in https://build.chromium.org/p/client.webrtc.perf/waterfall
* android_rel, android_dbg, android_arm64_rel in https://build.chromium.org/p/tryserver.webrtc/waterfall

I spent a little time trying to pass result_details=True and store_tombstones=True to our calls to runtest in scripts/slave/recipe_modules/chromium/api.py, but it didn't have any effect. I guess we're using different code paths. We're also planning to cleanup our own scripts/slave/recipe_modules/webrtc/steps.py so please keep ehmaldonado@ and myself in the loop if you end up making changes there.
Components: -Infra>Platform>Recipes Infra>Client>Android

Comment 7 by sakal@chromium.org, Aug 17 2017

Cc: sakal@chromium.org

Comment 8 by hzl@chromium.org, Aug 17 2017

I will work on this bug this week/the next week. Thanks for waiting.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/864b254c0f45fc72d3e51a619020ae304e546c48

commit 864b254c0f45fc72d3e51a619020ae304e546c48
Author: Zhiling Huang <hzl@chromium.org>
Date: Mon Aug 21 07:29:20 2017

Enable test results presentation for WebRTC bots.

Bug:717417
Change-Id: Iab210d66b18639590235491b04117b7eaf9004c6
Reviewed-on: https://chromium-review.googlesource.com/619228
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/864b254c0f45fc72d3e51a619020ae304e546c48/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7

commit 5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Mon Aug 21 07:59:22 2017

Revert "Enable test results presentation for WebRTC bots."

This reverts commit 864b254c0f45fc72d3e51a619020ae304e546c48.

Reason for revert: Builds are failing with
/usr/bin/python: can't open file '//build/android/pylib/results/presentation/test_results_presentation.py': [Errno 2] No such file or directory

I'll look into why it's not there. It's a part of the checkout but maybe not isolated properly on the swarming bots?

Original change's description:
> Enable test results presentation for WebRTC bots.
> 
> Bug:717417
> Change-Id: Iab210d66b18639590235491b04117b7eaf9004c6
> Reviewed-on: https://chromium-review.googlesource.com/619228
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

TBR=kjellander@chromium.org,hzl@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org

Change-Id: Id03900f69f1eb4ee7d35ed1f0f7eed0eedc56192
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  717417 
Reviewed-on: https://chromium-review.googlesource.com/622868
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/5c8d4d5ad4838fe30ee6db202d5084dbd5764aa7/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed

commit f8ff0282c6b605f16fa5464b9496be1f6bac35ed
Author: kjellander <kjellander@webrtc.org>
Date: Tue Sep 05 17:03:29 2017

Add //build/android/pylib/results/ to Android isolate packaging

This is needed before relanding
https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228

TESTED=
I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
is listed in the .isolated file:
OUT=out/android-Release
TEST=tools_unittests
tools_webrtc/mb/mb.py isolate //$OUT $TEST
tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated

BUG= chromium:717417 
NOTRY=True

Review-Url: https://codereview.webrtc.org/3006103002
Cr-Commit-Position: refs/heads/master@{#19695}

[modify] https://crrev.com/f8ff0282c6b605f16fa5464b9496be1f6bac35ed/webrtc/webrtc.gni

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1

commit e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1
Author: kjellander <kjellander@webrtc.org>
Date: Tue Sep 05 17:14:51 2017

Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )

Reason for revert:
Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554

Edward: do you understand why? I'll run a full CQ set before relanding for sure.

Original issue's description:
> Add //build/android/pylib/results/ to Android isolate packaging
>
> This is needed before relanding
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
>
> TESTED=
> I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> is listed in the .isolated file:
> OUT=out/android-Release
> TEST=tools_unittests
> tools_webrtc/mb/mb.py isolate //$OUT $TEST
> tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
>
> BUG= chromium:717417 
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/3006103002
> Cr-Commit-Position: refs/heads/master@{#19695}
> Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed

TBR=ehmaldonado@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:717417 

Review-Url: https://codereview.webrtc.org/3008083004
Cr-Commit-Position: refs/heads/master@{#19696}

[modify] https://crrev.com/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1/webrtc/webrtc.gni

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2e75bd4ed8a6111f9bc5b71de23a1dee41137415

commit 2e75bd4ed8a6111f9bc5b71de23a1dee41137415
Author: kjellander <kjellander@webrtc.org>
Date: Wed Sep 06 10:14:20 2017

Reland of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3008083004/ )

Reason for revert:
Now making sure the data attribute contents is not wiped for non-Android targets,
which caused every test relying on resources to break.

Original issue's description:
> Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )
>
> Reason for revert:
> Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554
>
> Edward: do you understand why? I'll run a full CQ set before relanding for sure.
>
> Original issue's description:
> > Add //build/android/pylib/results/ to Android isolate packaging
> >
> > This is needed before relanding
> > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> >
> > TESTED=
> > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> > is listed in the .isolated file:
> > OUT=out/android-Release
> > TEST=tools_unittests
> > tools_webrtc/mb/mb.py isolate //$OUT $TEST
> > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> >
> > BUG= chromium:717417 
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/3006103002
> > Cr-Commit-Position: refs/heads/master@{#19695}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed
>
> TBR=ehmaldonado@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= chromium:717417 
>
> Review-Url: https://codereview.webrtc.org/3008083004
> Cr-Commit-Position: refs/heads/master@{#19696}
> Committed: https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1

BUG= chromium:717417 

Review-Url: https://codereview.webrtc.org/3011023002
Cr-Commit-Position: refs/heads/master@{#19707}

[modify] https://crrev.com/2e75bd4ed8a6111f9bc5b71de23a1dee41137415/webrtc/webrtc.gni

Cc: hzl@chromium.org
Owner: kjellander@chromium.org
Status: Started (was: Assigned)
I'm relanding the buildbot change in https://chromium-review.googlesource.com/c/chromium/tools/build/+/652367 soon.
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bb55474e2b70d301f91631fcc4ae6fee338cdd8b

commit bb55474e2b70d301f91631fcc4ae6fee338cdd8b
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Sep 06 13:26:18 2017

Reland "Enable test results presentation for WebRTC bots."

Enable test results presentation for WebRTC bots. This relands
https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
again. The previous attempt failed due to
build/android/pylib/results/presentation/test_results_presentation.py
being missing in the isolated package on the bots.
This is fixed by https://codereview.webrtc.org/3011023002/

Bug:717417
Change-Id: I0985ad1148d4030fe2c0260ad2f17649b9188280
Reviewed-on: https://chromium-review.googlesource.com/652367
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/bb55474e2b70d301f91631fcc4ae6fee338cdd8b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24

commit 616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Sep 06 13:40:06 2017

Revert "Reland "Enable test results presentation for WebRTC bots.""

This reverts commit bb55474e2b70d301f91631fcc4ae6fee338cdd8b.

Reason for revert: Still breaks on the real bots:
https://luci-milo.appspot.com/buildbot/tryserver.webrtc/android_rel/27574


Original change's description:
> Reland "Enable test results presentation for WebRTC bots."
> 
> Enable test results presentation for WebRTC bots. This relands
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> again. The previous attempt failed due to
> build/android/pylib/results/presentation/test_results_presentation.py
> being missing in the isolated package on the bots.
> This is fixed by https://codereview.webrtc.org/3011023002/
> 
> Bug:717417
> Change-Id: I0985ad1148d4030fe2c0260ad2f17649b9188280
> Reviewed-on: https://chromium-review.googlesource.com/652367
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

TBR=kjellander@chromium.org,ehmaldonado@chromium.org

Change-Id: If9c1958fb1490e06373aa8fa4f8c06d72c01604e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  717417 
Reviewed-on: https://chromium-review.googlesource.com/652527
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1f5bda035c8f10bf9493b0c31b1d0b5fce03d8ab

commit 1f5bda035c8f10bf9493b0c31b1d0b5fce03d8ab
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Wed Sep 06 19:11:27 2017

Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #2 id:40001 of https://codereview.webrtc.org/3011023002/ )

Reason for revert:
This is not needed, since the script is run on the bot, not on a swarming task.

Original issue's description:
> Reland of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3008083004/ )
>
> Reason for revert:
> Now making sure the data attribute contents is not wiped for non-Android targets,
> which caused every test relying on resources to break.
>
> Original issue's description:
> > Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )
> >
> > Reason for revert:
> > Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554
> >
> > Edward: do you understand why? I'll run a full CQ set before relanding for sure.
> >
> > Original issue's description:
> > > Add //build/android/pylib/results/ to Android isolate packaging
> > >
> > > This is needed before relanding
> > > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> > >
> > > TESTED=
> > > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> > > is listed in the .isolated file:
> > > OUT=out/android-Release
> > > TEST=tools_unittests
> > > tools_webrtc/mb/mb.py isolate //$OUT $TEST
> > > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> > >
> > > BUG= chromium:717417 
> > > NOTRY=True
> > >
> > > Review-Url: https://codereview.webrtc.org/3006103002
> > > Cr-Commit-Position: refs/heads/master@{#19695}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed
> >
> > TBR=ehmaldonado@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= chromium:717417 
> >
> > Review-Url: https://codereview.webrtc.org/3008083004
> > Cr-Commit-Position: refs/heads/master@{#19696}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1
>
> BUG= chromium:717417 
>
> Review-Url: https://codereview.webrtc.org/3011023002
> Cr-Commit-Position: refs/heads/master@{#19707}
> Committed: https://chromium.googlesource.com/external/webrtc/+/2e75bd4ed8a6111f9bc5b71de23a1dee41137415

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:717417 

Review-Url: https://codereview.webrtc.org/3011063002
Cr-Commit-Position: refs/heads/master@{#19717}

[modify] https://crrev.com/1f5bda035c8f10bf9493b0c31b1d0b5fce03d8ab/webrtc/webrtc.gni

Owner: ehmaldonado@chromium.org
Edward is helping me out with this instead: https://chromium-review.googlesource.com/c/chromium/tools/build/+/653897
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0abc716ba0c0313e7a789ce49b12f01cfcd89138

commit 0abc716ba0c0313e7a789ce49b12f01cfcd89138
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Sep 07 12:48:06 2017

Reland "Enable test results presentation for WebRTC bots."

This reverts commit 616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24.

Reason for revert:
I think we need to specify a real path.

Original change's description:
> Revert "Reland "Enable test results presentation for WebRTC bots.""
> 
> This reverts commit bb55474e2b70d301f91631fcc4ae6fee338cdd8b.
> 
> Reason for revert: Still breaks on the real bots:
> https://luci-milo.appspot.com/buildbot/tryserver.webrtc/android_rel/27574
> 
> 
> Original change's description:
> > Reland "Enable test results presentation for WebRTC bots."
> > 
> > Enable test results presentation for WebRTC bots. This relands
> > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> > again. The previous attempt failed due to
> > build/android/pylib/results/presentation/test_results_presentation.py
> > being missing in the isolated package on the bots.
> > This is fixed by https://codereview.webrtc.org/3011023002/
> > 
> > Bug:717417
> > Change-Id: I0985ad1148d4030fe2c0260ad2f17649b9188280
> > Reviewed-on: https://chromium-review.googlesource.com/652367
> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> > Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> 
> TBR=kjellander@chromium.org,ehmaldonado@chromium.org
> 
> Change-Id: If9c1958fb1490e06373aa8fa4f8c06d72c01604e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  717417 
> Reviewed-on: https://chromium-review.googlesource.com/652527
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

TBR=kjellander@chromium.org,ehmaldonado@chromium.org

Change-Id: I0d210d45ba3b638b3bed5d122f6e0febb43d6c0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  717417 
Reviewed-on: https://chromium-review.googlesource.com/653897
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/0abc716ba0c0313e7a789ce49b12f01cfcd89138/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ace6c1086bdf087a381e91f56efc23cd0df23773

commit ace6c1086bdf087a381e91f56efc23cd0df23773
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Thu Sep 07 13:08:16 2017

Revert "Reland "Enable test results presentation for WebRTC bots.""

This reverts commit 0abc716ba0c0313e7a789ce49b12f01cfcd89138.

Reason for revert:
Breaks builds.
Command was invoked incorrectly:
https://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27513/steps/AppRTCMobileTest%20on%20Android/logs/stdio

Original change's description:
> Reland "Enable test results presentation for WebRTC bots."
> 
> This reverts commit 616b0eaa71e11c9fa3a0d64fc4a570984d7b8c24.
> 
> Reason for revert:
> I think we need to specify a real path.
> 
> Original change's description:
> > Revert "Reland "Enable test results presentation for WebRTC bots.""
> > 
> > This reverts commit bb55474e2b70d301f91631fcc4ae6fee338cdd8b.
> > 
> > Reason for revert: Still breaks on the real bots:
> > https://luci-milo.appspot.com/buildbot/tryserver.webrtc/android_rel/27574
> > 
> > 
> > Original change's description:
> > > Reland "Enable test results presentation for WebRTC bots."
> > > 
> > > Enable test results presentation for WebRTC bots. This relands
> > > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> > > again. The previous attempt failed due to
> > > build/android/pylib/results/presentation/test_results_presentation.py
> > > being missing in the isolated package on the bots.
> > > This is fixed by https://codereview.webrtc.org/3011023002/
> > > 
> > > Bug:717417
> > > Change-Id: I0985ad1148d4030fe2c0260ad2f17649b9188280
> > > Reviewed-on: https://chromium-review.googlesource.com/652367
> > > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> > > Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> > 
> > TBR=kjellander@chromium.org,ehmaldonado@chromium.org
> > 
> > Change-Id: If9c1958fb1490e06373aa8fa4f8c06d72c01604e
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  717417 
> > Reviewed-on: https://chromium-review.googlesource.com/652527
> > Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> > Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> 
> TBR=kjellander@chromium.org,ehmaldonado@chromium.org
> 
> Change-Id: I0d210d45ba3b638b3bed5d122f6e0febb43d6c0a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  717417 
> Reviewed-on: https://chromium-review.googlesource.com/653897
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=kjellander@chromium.org,ehmaldonado@chromium.org

Change-Id: I06804ba8016629b69d22427a21c3469bceef7145
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  717417 
Reviewed-on: https://chromium-review.googlesource.com/655084
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/ace6c1086bdf087a381e91f56efc23cd0df23773/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

I realized that the test results presentation generates a file like [1], which might be useful, but is not what we're looking for with this bug (i.e. a link in the result presentation to the logcat results).

I'll start looking into how to get them and display them.
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/34623ce83ad40fe5fa29c044f5839b51b1064f55

commit 34623ce83ad40fe5fa29c044f5839b51b1064f55
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Fri Sep 08 14:03:13 2017

WebRTC: Save logcat output to isolated outputs.

NOTRY=True
BUG= chromium:717417 

Review-Url: https://codereview.webrtc.org/3008343002
Cr-Commit-Position: refs/heads/master@{#19748}

[modify] https://crrev.com/34623ce83ad40fe5fa29c044f5839b51b1064f55/tools_webrtc/mb/mb.py
[modify] https://crrev.com/34623ce83ad40fe5fa29c044f5839b51b1064f55/tools_webrtc/mb/mb_unittest.py

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9b58e9511518090373690ca878ca1fbabdc50b21

commit 9b58e9511518090373690ca878ca1fbabdc50b21
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Fri Sep 08 19:20:29 2017

WebRTC: Add logcats link to all Android bots.

Bug:  717417 
Change-Id: Ida94c027f9fab245d41d9db0dd7c108e056f83ca
Reviewed-on: https://chromium-review.googlesource.com/657659
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/9b58e9511518090373690ca878ca1fbabdc50b21/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_asan__swarming_.json

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/1359744d72ff91cc284a7372803613f3d0f9ed58

commit 1359744d72ff91cc284a7372803613f3d0f9ed58
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Fri Sep 08 20:42:00 2017

Whitespace CL - Test changes to android bots.

TBR=kjellander@webrtc.org
BUG= chromium:717417 

Review-Url: https://codereview.webrtc.org/3012933002
Cr-Commit-Position: refs/heads/master@{#19757}

[modify] https://crrev.com/1359744d72ff91cc284a7372803613f3d0f9ed58/tools_webrtc/whitespace.txt

Status: Fixed (was: Started)

Sign in to add a comment