New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717415 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

testlog: none in path

Project Member Reported by hungte@chromium.org, May 2 2017

Issue description

Found from reef factory branch.

[ERROR] goofy invocation.py:829 2017-04-28 21:59:51.687 Unable to log end_test event
Traceback (most recent call last):
  File "/usr/local/factory/py_pkg/cros/factory/goofy/invocation.py", line 824, in _run
    log_args, status))
  File "/usr/local/factory/py_pkg/cros/factory/test/testlog.py", line 306, in LogFinalTestRun
    LogTestRun(session_json_path, station_test_run)
  File "/usr/local/factory/py_pkg/cros/factory/test/testlog.py", line 288, in LogTestRun
    with file_utils.FileLockContextManager(session_json_path, 'r') as fd:
  File "/usr/local/factory/py_pkg/cros/factory/utils/file_utils.py", line 736, in __enter__
    self._OpenUnlocked()
  File "/usr/local/factory/py_pkg/cros/factory/utils/file_utils.py", line 755, in _OpenUnlocked
    parent_dir = os.path.dirname(self.path)
  File "/usr/local/lib64/python2.7/posixpath.py", line 122, in dirname
    i = p.rfind('/') + 1
AttributeError: 'NoneType' object has no attribute 'rfind'


I don't know if this has been fixed or not on ToT - please try to verify and fix ToT & reef factory branch.
 

Comment 1 by hungte@chromium.org, May 16 2017

Labels: -Pri-3 Pri-1
Status: Assigned (was: Untriaged)
I'm seeing this on ToT (Eve logs) as well. Please check what we should do.

Comment 2 by hungte@chromium.org, May 18 2017

Cc: petershih@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/3d041c6fa3ffafeac9bdc27e86c0aad34949d5f2

commit 3d041c6fa3ffafeac9bdc27e86c0aad34949d5f2
Author: chuntsen <chuntsen@google.com>
Date: Fri Jun 30 14:57:47 2017

Testlog: Fix path not found in resume test

We lose session_json_path after reboot. Recover the information to log
correctly.

BUG= chromium:717415 
TEST=Manually test on DUT
CQ-DEPEND=CL:536223

Change-Id: I809a5ba5931dc087eca53731aaac0a88ebe739f9
Reviewed-on: https://chromium-review.googlesource.com/538494
Commit-Ready: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Reviewed-by: Chun-ta Lin <itspeter@chromium.org>
Reviewed-by: Chun-Tsen Kuo <chuntsen@chromium.org>

[modify] https://crrev.com/3d041c6fa3ffafeac9bdc27e86c0aad34949d5f2/py/goofy/invocation.py

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment