Fix all the failures on the Mac RandomOrder bot |
||||||
Issue descriptionTo deploy LayoutTests on Swarming for Mac, we need to fix all the tests which are currently failing. https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Mac%20-%20RandomOrder/ webkit_layout_tests ( 2 mins 17 secs ) webkit_layout_tests Total tests: 69795 * Passed: 50384 (50307 expected, 77 unexpected) * Skipped: 18550 (18550 expected, 0 unexpected) * Failed: 861 (740 expected, >>>121 unexpected<<<) * Flaky: 0 (0 expected, 0 unexpected)
,
May 2 2017
Unexpected Failures: * battery-status/api-defined.html * battery-status/multiple-promises-after-resolve.html * battery-status/multiple-promises.html * battery-status/multiple-windows-page-visibility.html * battery-status/multiple-windows.html * battery-status/no-gc-with-eventlisteners.html * battery-status/page-visibility.html * battery-status/promise-with-eventlisteners.html * battery-status/restricted-level-precision.html * bluetooth/requestDevice/le-not-supported.html * css2.1/t040304-c64-uri-00-a-g.html * external/wpt/IndexedDB/interleaved-cursors.html * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html * external/wpt/uievents/auxclick/auxclick_event-manual.html * external/wpt/uievents/mouse/mouseevent_move_button-manual.html * external/wpt/uievents/order-of-events/focus-events/focus-manual.html * fast/dom/shadow/import-rule-in-shadow-tree-needs-document-style-recalc.html * fast/events/wheel/mouse-wheel-scroll-latching.html * fast/text/variable-fonts/variable-gpos-m2b.html * geolocation-api/callback-exception.html * geolocation-api/callback-to-remote-context.html * geolocation-api/clear-watch-invalid-id-crash.html * geolocation-api/delayed-permission-allowed-for-multiple-requests.html * geolocation-api/delayed-permission-allowed.html * geolocation-api/delayed-permission-denied-for-multiple-requests.html * geolocation-api/delayed-permission-denied.html * geolocation-api/disconnected-frame-already.html * geolocation-api/disconnected-frame-permission-denied.html * geolocation-api/disconnected-frame.html * geolocation-api/maximum-age.html * ... 91 more ...
,
May 2 2017
,
May 2 2017
First thing to check is that we are running on the right Mac OS version (when running on swarming).
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f04dad2bfc98e46549ed50978c36d05a3c48c505 commit f04dad2bfc98e46549ed50978c36d05a3c48c505 Author: tansell <tansell@chromium.org> Date: Tue May 02 11:52:03 2017 buildbot: Force OS on the Mac WebKit RandomOrder bot. The local VM is Mac-10.12 and the LayoutTests are passing, so force swarming to also run on Mac-10.12 BUG= 717344 TBR=dpranke@chromium.com,mcgreevy@chromium.org Review-Url: https://codereview.chromium.org/2848253005 Cr-Commit-Position: refs/heads/master@{#468602} [modify] https://crrev.com/f04dad2bfc98e46549ed50978c36d05a3c48c505/testing/buildbot/chromium.fyi.json
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e68a5f95ca744d875773e3bb12b79ec180a5bd9 commit 4e68a5f95ca744d875773e3bb12b79ec180a5bd9 Author: tansell <tansell@chromium.org> Date: Tue May 02 13:07:59 2017 buildbot: Force OS on the Win WebKit RandomOrder bot. The local VM is Windows 10 and the LayoutTests are passing, so force swarming to also run on Windows 10. BUG= 717344 TBR=dpranke@chromium.com,mcgreevy@chromium.org Review-Url: https://codereview.chromium.org/2850423002 Cr-Commit-Position: refs/heads/master@{#468613} [modify] https://crrev.com/4e68a5f95ca744d875773e3bb12b79ec180a5bd9/testing/buildbot/chromium.fyi.json
,
May 2 2017
Fixing the OS had no effect on number of tests failing for Mac.
,
Jun 8 2017
So it looks like a lot of the tests are failing because of missing mojo files; 00:27:58.039 42616 [50419:775:0607/002752.189275:11385249985473:ERROR:mojo_context_state.cc(207)] Failed to fetch source for module "device/geolocation/public/interfaces/geolocation.mojom" 00:27:58.039 42616 [50419:775:0607/002752.189388:11385250090228:ERROR:mojo_context_state.cc(207)] Failed to fetch source for module "third_party/WebKit/public/platform/modules/permissions/permission.mojom" 00:27:58.039 42616 [50419:775:0607/002752.189455:11385250156256:ERROR:mojo_context_state.cc(207)] Failed to fetch source for module "third_party/WebKit/public/platform/modules/permissions/permission_status.mojom" These mojo files are not being included in the isolate on Mac because of broken build files. I'm testing a temporary fix in https://codereview.chromium.org/2926843002/
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8f9e65ca0db08280344fb615c3a841622fc14ae commit a8f9e65ca0db08280344fb615c3a841622fc14ae Author: tansell <tansell@chromium.org> Date: Thu Jun 08 07:32:23 2017 Fixing data_deps on Mac for content_shell Temporary fix to check if this ends up with the mojo.js generated files get correctly included. BUG= 717344 TBR=dpranke@chromium.org,jochen@chromium.org,mcgreevy@chromium.org Review-Url: https://codereview.chromium.org/2926843002 Cr-Commit-Position: refs/heads/master@{#477918} [modify] https://crrev.com/a8f9e65ca0db08280344fb615c3a841622fc14ae/content/shell/BUILD.gn
,
Jun 8 2017
https://crbug.com/2926843002 reduced the number of failures down to 5! ---------------------------- webkit_layout_tests on Mac-10.12 webkit_layout_tests on Mac-10.12 Run on OS: 'Mac-10.12' Total tests: 68280 * Passed: 57288 (57127 expected, 161 unexpected) * Skipped: 9414 (9414 expected, 0 unexpected) * Failed: 1481 (1476 expected, >>>5 unexpected<<<) * Flaky: 97 (97 expected, 0 unexpected) Unexpected Failures: * http/tests/media/progress-events-generated-correctly.html * sensor/ambient-light-sensor.html * sensor/gyroscope.html * sensor/orientation-sensor.html * virtual/mojo-loading/http/tests/media/video-load-metadata-decode-error.html ----------------------------
,
Jun 8 2017
Regressions: Unexpected text-only failures (4) http/tests/media/progress-events-generated-correctly.html [ Failure ] sensor/ambient-light-sensor.html [ Failure ] sensor/gyroscope.html [ Failure ] sensor/orientation-sensor.html [ Failure ] Regressions: Unexpected timeouts (1) virtual/mojo-loading/http/tests/media/video-load-metadata-decode-error.html [ Timeout ]
,
Jun 8 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef284701964ccddc1c0878926e32d6ffc0254a59 commit ef284701964ccddc1c0878926e32d6ffc0254a59 Author: tansell <tansell@chromium.org> Date: Thu Jun 08 11:12:49 2017 LayoutTests: Disabling sensor tests which fail on Mac swarming. The following layout tests fail on Mac when run on the swarming bots; * sensor/accelerometer.html * sensor/ambient-light-sensor.html * sensor/gyroscope.html * sensor/orientation-sensor.html The problem seems to be related to frequency being limited to 60Hz? BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org Review-Url: https://codereview.chromium.org/2925243002 Cr-Commit-Position: refs/heads/master@{#477940} [modify] https://crrev.com/ef284701964ccddc1c0878926e32d6ffc0254a59/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2017
We seem to be down to one or two tests failing now! I'm hoping that we can get a green run tomorrow.
,
Jun 8 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56752fc224c8d7af28f92332edca9d1853f25626 commit 56752fc224c8d7af28f92332edca9d1853f25626 Author: tansell <tansell@chromium.org> Date: Thu Jun 08 15:12:31 2017 LayoutTests: Disabling sensor tests which fail on Mac swarming. The following layout tests fail on Mac when run on the swarming bots; * sensor/magnetometer.html The problem seems to be related to frequency being limited to 60Hz? BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org Review-Url: https://codereview.chromium.org/2926073004 Cr-Commit-Position: refs/heads/master@{#477970} [modify] https://crrev.com/56752fc224c8d7af28f92332edca9d1853f25626/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56752fc224c8d7af28f92332edca9d1853f25626 commit 56752fc224c8d7af28f92332edca9d1853f25626 Author: tansell <tansell@chromium.org> Date: Thu Jun 08 15:12:31 2017 LayoutTests: Disabling sensor tests which fail on Mac swarming. The following layout tests fail on Mac when run on the swarming bots; * sensor/magnetometer.html The problem seems to be related to frequency being limited to 60Hz? BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org Review-Url: https://codereview.chromium.org/2926073004 Cr-Commit-Position: refs/heads/master@{#477970} [modify] https://crrev.com/56752fc224c8d7af28f92332edca9d1853f25626/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/164a8cfd9fee87f1bee4255f1db2258b5b71bd5b commit 164a8cfd9fee87f1bee4255f1db2258b5b71bd5b Author: tansell <tansell@chromium.org> Date: Thu Jun 08 16:40:59 2017 LayoutTests: Disabling media tests which fail on Mac swarming. The following layout tests fail on Mac when run on the swarming bots; * http/tests/media/progress-events-generated-correctly.html * http/tests/media/video-load-metadata-decode-error.html * virtual/mojo-loading/http/tests/media/progress-events-generated-correctly.html * virtual/mojo-loading/http/tests/media/video-load-metadata-decode-error.html BUG= 731111 , 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2924233003 Cr-Commit-Position: refs/heads/master@{#477995} [modify] https://crrev.com/164a8cfd9fee87f1bee4255f1db2258b5b71bd5b/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 9 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db3258114828a8013686b1ade97f60d4e8211308 commit db3258114828a8013686b1ade97f60d4e8211308 Author: tansell <tansell@chromium.org> Date: Thu Jun 22 06:42:31 2017 LayoutTests: The sensor tests are crashing when DCHECK is enabled (on Mac) BUG=731018, 717344 TBR=mcgreevy@chromium.org,dpranke@chromium.org,qyearsley@chromium.org,reillyg@chromium.org,alexander.shalamov@intel.com NOTRY=true Review-Url: https://codereview.chromium.org/2950063003 Cr-Commit-Position: refs/heads/master@{#481467} [modify] https://crrev.com/db3258114828a8013686b1ade97f60d4e8211308/third_party/WebKit/LayoutTests/TestExpectations |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tansell@chromium.org
, May 2 2017