New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[CFM Test Automation] Automate test for volume change operation being in sync after hotplug 1 jabra on a CFM setup with dual jabras

Project Member Reported by harpreet@chromium.org, May 2 2017

Issue description

To catch issues like: crbug.com/500057


1. CFM setup with 2 jabra speakers; 1 connected via servo to allow for hotplugging
2. After enrollment and hangouts OOBE; change speaker volume
3. Verify that the volume change is reflected for both speakers
4. Use servo to unplug / replug 1 jabra speaker
5. Change speaker volume
6. Verify that the volume change is reflected for both speakers
 
Cc: hychao@chromium.org
hychao@ - whats a good way to verify that volume change is reflected on both speakers? Using amixer or something else?
Cc: -dsunk...@chromium.org
Owner: dsunk...@chromium.org
Cc: -mzhuo@chromium.org dsunk...@chromium.org
Components: -UI>Shell>Kiosk
Owner: mzhuo@chromium.org
https://chromium-review.googlesource.com/273458 

The above change adds 'SetOutputNodeVolume' dbus method to cras_utils. Similarly you can use get_cras_control_interface().GetOutputNodeVolume(node_id) to query and verify if node volume is correct.
Cc: mnilsson@chromium.org katierh@chromium.org ar...@chromium.org
Status: Assigned (was: Untriaged)
Components: UI>Shell>Kiosk
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3bc919c4197f6cca269e2fb3ad0004615921ad54

commit 3bc919c4197f6cca269e2fb3ad0004615921ad54
Author: Min Zhuo <mzhuo@google.com>
Date: Fri Sep 29 21:35:29 2017

Tests Hotrod App and CfM are in sync for mute, unmute and changing
volume when there are dual speakers.

1. The state of mute/umute should be sync between CfM and speakers.
2. The volume of two speakers should be sync to volume set by CfM.
3. When doing mute/unmute speakers from CfM, (1) remains valid.
4. When changing volume from CfM, (2) remains valid.
5. After disconnect/re-connect any speaker, the above 4 remain valid.

BUG= chromium:717332 , 708884,  660188 
TEST=Tested against local setup.

pre-cq-configs: bluestreak-pre-cq

Change-Id: Ie0b659d9a7e5611d7cf19235d4b7d45477868e88
Reviewed-on: https://chromium-review.googlesource.com/566293
Commit-Ready: Min Zhuo <mzhuo@chromium.org>
Tested-by: Min Zhuo <mzhuo@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Min Zhuo <mzhuo@chromium.org>

[add] https://crrev.com/3bc919c4197f6cca269e2fb3ad0004615921ad54/server/site_tests/enterprise_CFM_DualSpeaker/control
[modify] https://crrev.com/3bc919c4197f6cca269e2fb3ad0004615921ad54/client/common_lib/cros/power_cycle_usb_util.py
[add] https://crrev.com/3bc919c4197f6cca269e2fb3ad0004615921ad54/server/site_tests/enterprise_CFM_DualSpeaker/enterprise_CFM_DualSpeaker.py

Comment 8 by dtosic@chromium.org, Nov 13 2017

This test was never added to an ebuild file, please fix

Comment 9 by dtosic@chromium.org, Nov 13 2017

Cc: malmnas@google.com
Owner: dtosic@chromium.org
Status: Started (was: Assigned)
The test needs a major overhaul, I'll take care of it.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0ef16c3dd5d7ed953188fb256a08060f649668e2

commit 0ef16c3dd5d7ed953188fb256a08060f649668e2
Author: Denis Tosic <dtosic@chromium.org>
Date: Tue Nov 14 10:56:01 2017

[autotest][cfm] Improve readbility and docstrings

Does not change any logic in the test.

TEST=local setup
BUG= chromium:717332 

Change-Id: Idd87fe3c0b5ac1904d6e72b5afa8baae6b8f377d
Reviewed-on: https://chromium-review.googlesource.com/768411
Tested-by: Denis Tosic <dtosic@chromium.org>
Trybot-Ready: Denis Tosic <dtosic@chromium.org>
Reviewed-by: Claes Malmnäs <malmnas@google.com>
Reviewed-by: Denis Tosic <dtosic@chromium.org>

[modify] https://crrev.com/0ef16c3dd5d7ed953188fb256a08060f649668e2/server/site_tests/enterprise_CFM_DualSpeaker/control
[modify] https://crrev.com/0ef16c3dd5d7ed953188fb256a08060f649668e2/server/site_tests/enterprise_CFM_DualSpeaker/enterprise_CFM_DualSpeaker.py

Owner: mzhuo@chromium.org
Status: Assigned (was: Started)
@Min- back to you. Once https://crrev.com/c/768413 is submitted the test basic test form will run on presubmit.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ece6aba7be2d54a10a3e4efe006a6a8953b5ea4a

commit ece6aba7be2d54a10a3e4efe006a6a8953b5ea4a
Author: Denis Tosic <dtosic@chromium.org>
Date: Wed Nov 15 15:36:22 2017

[autotest][cfm] Add enterprise_CFM_DualSpeaker test to the ebuild file

TEST=local setup
BUG= chromium:717332 

Change-Id: I2181dd74bf9098f79c317caf07686f73961a06ee
Reviewed-on: https://chromium-review.googlesource.com/768413
Commit-Ready: Denis Tosic <dtosic@chromium.org>
Tested-by: Denis Tosic <dtosic@chromium.org>
Reviewed-by: Claes Malmnäs <malmnas@google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>

[modify] https://crrev.com/ece6aba7be2d54a10a3e4efe006a6a8953b5ea4a/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild

There is no lab device with the dual_jabra tag which is specified in the control file (http://cs/aosp-master/external/autotest/server/site_tests/enterprise_CFM_DualSpeaker/control?l=14&rcl=b8ffcbb46a980d2ed275eab4044d75433d4d10ba).

Can we get this fixed?

Comment 14 by tovep@chromium.org, Dec 20 2017

Labels: Hotrod-Testing
Status: Fixed (was: Assigned)

Sign in to add a comment