New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717324 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

In CQ runs, change "DetectIrrelevantChanges" to "DetectRelevantChanges"

Reported by jrbarnette@chromium.org, May 2 2017

Issue description

For each board in a CQ run, after building we check which
CLs actually contributed to the built image.  We then
make a report in a "DetectIrrelevantChanges" stage.

A common use case problem is to look at all the CLs in
a run, and ask the question "which of these CLs could have
caused the problem?"  To answer that question, what's needed
is the list of _relevant_ CLs, not the _irrelevant_ CLs.

We should change the stage to be "DetectRelevantChanges",
so that each paladin can make a candidate blamelist for its
particular failures.

 
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ab87b5b47686e0ecc256abcc61e876fc3367efd4

commit ab87b5b47686e0ecc256abcc61e876fc3367efd4
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed May 03 20:15:45 2017

Change DetectIrrelevantChanges to DetectRelevantChanges.

This changes the name of the DetectIrrelevantChanges stage to
DetectRelevantChanges.  The behavior is altered so that the blamelist
links it logs are to changes relevant to the builder, rather than
to the irrelevant changes.

Metadata and CIDB content are not changed.

BUG= chromium:717324 
TEST=Unit tests

Change-Id: Ib7bac47bd37f583060476a0343bf29446d058842
Reviewed-on: https://chromium-review.googlesource.com/493801
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/ab87b5b47686e0ecc256abcc61e876fc3367efd4/cbuildbot/stages/report_stages.py
[modify] https://crrev.com/ab87b5b47686e0ecc256abcc61e876fc3367efd4/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/ab87b5b47686e0ecc256abcc61e876fc3367efd4/cbuildbot/builders/simple_builders.py

Comment 3 by aut...@google.com, May 5 2017

Labels: -current-issue
Owner: jrbarnette@chromium.org
Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment