All the UI elements in the Payment Request dialog that can be interacted with should be focusable.
Moreover, pushing/popping a new sheet should focus the correct element in the topmost sheet.
Remaining issues with focus:
- Vector icons (pencils, back arrow) need to visually change when focused
- Choose appropriate initial focus target for each sheet
- Scrollable views should move if an off-screen field is focused
- Enter button doesn't activate buttons
I think most of the issues you list above are Mac-only? I recognize some of the things in your list as being fixed in #c2 and #c3 on other platforms at least.
Also please Merge-Request-60 for #c4 and open bugs for remaining Mac issues (individual bugs makes merging easier)
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
On Linux, Mac, and Windows:
1) Open https://rsolomakhin.github.io/pr/expl/
2) Click "Buy" on the page.
3) Verify: pressing Tab on the keyboard moves focus through all clickable views.
4) Open the order summary page.
5) Verify: pressing Tab on the keyboard moves focus through all clickable views.
6) Open the shipping address selector.
7) Verify: pressing Tab on the keyboard moves focus through all clickable views.
8) Open the address editor.
9) Verify: pressing Tab on the keyboard moves focus through all clickable views.
9) Open the card selector.
10) Verify: pressing Tab on the keyboard moves focus through all clickable views.
11) Open the card editor.
12) Verify: pressing Tab on the keyboard moves focus through all clickable views.
13) Open https://rsolomakhin.github.io/pr/contact/
14) Click "Buy" on the page.
15) Verify: pressing Tab on the keyboard moves focus through all clickable views.
16) Open the contact info selector.
17) Verify: pressing Tab on the keyboard moves focus through all clickable views.
18) Open the contact info editor.
19) Verify: pressing Tab on the keyboard moves focus through all clickable views.
Comment 1 by anthonyvd@chromium.org
, May 2 2017