New issue
Advanced search Search tips

Issue 717320 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 575762



Sign in to add a comment

Migrate oilpan_gc_times.* benchmarks to tools/perf/contrib

Project Member Reported by nedngu...@google.com, May 2 2017

Issue description

These benchmarks doesn't fit into our supported harnesses. It could be rewritten to fit into the blink_perf tracing harness but right now we don't have anyone who can help with migration. Since these are mostly use locally & with trybot, moving the benchmarks code to tools/perf/contrib is probably the best course of action for now.
 
Blockedon: 717321
Blockedon: -717321
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b

commit ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b
Author: Nghia Nguyen <NghiaNguyenBH@gmail.com>
Date: Tue May 02 10:59:35 2017

Move oiplan benchmarks & related code to tools/perf/contrib/ directory

This makes oilpan benchmarks no longer run on perf waterfall. However,
these benchmarks are still runnable locally & on try bot.

Bug:  717320 
Change-Id: I4eb52a6a8306a03879c808821f25238dfc5bb49e
Reviewed-on: https://chromium-review.googlesource.com/492806
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#468594}
[modify] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/tools/perf/benchmark.csv
[add] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/tools/perf/contrib/oilpan/OWNERS
[add] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/tools/perf/contrib/oilpan/__init__.py
[rename] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/tools/perf/contrib/oilpan/oilpan_benchmarks.py
[rename] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/tools/perf/contrib/oilpan/oilpan_gc_times.py
[rename] https://crrev.com/ae5512e5d564f1a26e07c79bcc96bf2a27e68f5b/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py

Owner: nedngu...@google.com
Status: Fixed (was: Untriaged)

Sign in to add a comment