New issue
Advanced search Search tips

Issue 717309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

OmniboxPerfTest.TestTypingInTextField crashes in ChromeOmniboxClientIOS::GetTitle()

Project Member Reported by pkl@chromium.org, May 1 2017

Issue description

controller_->GetWebState() returned nil and test crashed when it is dereferenced.
 

Comment 1 by pkl@chromium.org, May 1 2017

Cc: kkhorimoto@chromium.org justincohen@chromium.org
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
I actually don't know who's the best person to assign this...
OmniboxPerfTest.TestTypeOneCharInTextField was also disabled with this bug.
Cc: -justincohen@chromium.org eugene...@chromium.org
Owner: justincohen@chromium.org
Sounds like omnibox test problem which did not configure web state properly.

Comment 5 by pkl@chromium.org, May 5 2017

Cc: justincohen@chromium.org
Owner: pkl@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37902cbceb02b72f5e904fc2ace9167a7acb3823

commit 37902cbceb02b72f5e904fc2ace9167a7acb3823
Author: pkl <pkl@chromium.org>
Date: Tue May 09 13:26:45 2017

Enables omnibox_perftest that were failing.

Added more TestWebState scaffolding for the tests to run.

BUG= 717309 

Review-Url: https://codereview.chromium.org/2867593002
Cr-Commit-Position: refs/heads/master@{#470306}

[modify] https://crrev.com/37902cbceb02b72f5e904fc2ace9167a7acb3823/ios/chrome/browser/ui/omnibox_perftest.mm

Comment 7 by pkl@chromium.org, May 10 2017

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment