New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 703328



Sign in to add a comment

Extract report from swarmbucket tryjob

Project Member Reported by robert...@chromium.org, May 1 2017

Issue description

For retrieving the report from logdog for buildbot builds, a logdog path such as bb/tryserver.chromium.linux/linux_chromium_variable/12022/+/recipes/annotations is composed to get the annotations, locate the right step and log and then use that to retrieve the log in question.

This is not directly translatable to swarmbucket tryjobs because the path in this case includes the run_id instead of the related swarming_task_id.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cc857f4e69b73143ecc60af9f10a10f6102ae15f

commit cc857f4e69b73143ecc60af9f10a10f6102ae15f
Author: Stephen Martinis <martiniss@chromium.org>
Date: Wed May 03 22:37:51 2017

Revert "[Findit] Get step log for swarmbucket jobs."

This reverts commit 390470889c00e2c50d738fa26bf266b8c682fdb1.

Reason for revert: Speculative revert, https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-64/builds/7058 failed.

Original change's description:
> [Findit] Get step log for swarmbucket jobs.
> 
> This change uses the log_location swarming tag from the buildbucket
> output, and uses it to get the annotations proto from logdog.
> 
> R=​chanli,lijeffrey,stgao
> BUG= 717307 
> 
> Change-Id: I7c828e6d9a0297d3fbe8fb4b3100baa8f37ba359
> Reviewed-on: https://chromium-review.googlesource.com/492487
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> Reviewed-by: Chan Li <chanli@chromium.org>
> Reviewed-by: Shuotao Gao <stgao@chromium.org>
> 

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 717307 

Change-Id: I6642ba3c3fe56b614203b7590b6d9f86b1244f66
Reviewed-on: https://chromium-review.googlesource.com/495367
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/cc857f4e69b73143ecc60af9f10a10f6102ae15f/appengine/findit/waterfall/test/buildbot_test.py
[modify] https://crrev.com/cc857f4e69b73143ecc60af9f10a10f6102ae15f/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/cc857f4e69b73143ecc60af9f10a10f6102ae15f/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/cc857f4e69b73143ecc60af9f10a10f6102ae15f/appengine/findit/infra_api_clients/test/logdog_util_test.py
[modify] https://crrev.com/cc857f4e69b73143ecc60af9f10a10f6102ae15f/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/cc857f4e69b73143ecc60af9f10a10f6102ae15f/appengine/findit/waterfall/buildbot.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fa4aabf5e37371c7c771c02b4b83abcce7888e88

commit fa4aabf5e37371c7c771c02b4b83abcce7888e88
Author: Roberto Carrillo <robertocn@chromium.org>
Date: Thu May 04 00:24:50 2017

Revert "[RELAND][Findit] Get step log for swarmbucket jobs."

This reverts commit 01b38a4b7111423a1c5180708867a786eb60058b.

Reason for revert: Broke again

Original change's description:
> [RELAND][Findit] Get step log for swarmbucket jobs.
> 
> The issue with the original patch is that it used a real http client for
> testing instead of a fake one.
> 
> Original change's description
> > This change uses the log_location swarming tag from the buildbucket
> > output, and uses it to get the annotations proto from logdog.
> 
> > R=chanli,lijeffrey,stgao
> > BUG= 717307 
> 
> > Change-Id: I7c828e6d9a0297d3fbe8fb4b3100baa8f37ba359
> > Reviewed-on: https://chromium-review.googlesource.com/492487
> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> > Reviewed-by: Chan Li <chanli@chromium.org>
> > Reviewed-by: Shuotao Gao <stgao@chromium.org>
> R=​stgao,lijeffrey,chanli
> 
> Bug:
> 
> Change-Id: Ib06588a429236c5c8a0a04857c78a789c1115e39
> Reviewed-on: https://chromium-review.googlesource.com/495686
> Reviewed-by: Chan Li <chanli@chromium.org>
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> 

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: If91c43b5681d7346e9f7830a7dc148ec2baa574f
Reviewed-on: https://chromium-review.googlesource.com/495866
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/test/buildbot_test.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/infra_api_clients/test/logdog_util_test.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/buildbot.py

Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fa4aabf5e37371c7c771c02b4b83abcce7888e88

commit fa4aabf5e37371c7c771c02b4b83abcce7888e88
Author: Roberto Carrillo <robertocn@chromium.org>
Date: Thu May 04 00:24:50 2017

Revert "[RELAND][Findit] Get step log for swarmbucket jobs."

This reverts commit 01b38a4b7111423a1c5180708867a786eb60058b.

Reason for revert: Broke again

Original change's description:
> [RELAND][Findit] Get step log for swarmbucket jobs.
> 
> The issue with the original patch is that it used a real http client for
> testing instead of a fake one.
> 
> Original change's description
> > This change uses the log_location swarming tag from the buildbucket
> > output, and uses it to get the annotations proto from logdog.
> 
> > R=chanli,lijeffrey,stgao
> > BUG= 717307 
> 
> > Change-Id: I7c828e6d9a0297d3fbe8fb4b3100baa8f37ba359
> > Reviewed-on: https://chromium-review.googlesource.com/492487
> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> > Reviewed-by: Chan Li <chanli@chromium.org>
> > Reviewed-by: Shuotao Gao <stgao@chromium.org>
> R=​stgao,lijeffrey,chanli
> 
> Bug:
> 
> Change-Id: Ib06588a429236c5c8a0a04857c78a789c1115e39
> Reviewed-on: https://chromium-review.googlesource.com/495686
> Reviewed-by: Chan Li <chanli@chromium.org>
> Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
> 

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: If91c43b5681d7346e9f7830a7dc148ec2baa574f
Reviewed-on: https://chromium-review.googlesource.com/495866
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/test/buildbot_test.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/infra_api_clients/test/logdog_util_test.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/fa4aabf5e37371c7c771c02b4b83abcce7888e88/appengine/findit/waterfall/buildbot.py

Status: Fixed (was: Started)

Sign in to add a comment