New issue
Advanced search Search tips

Issue 717305 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Implement offline prefetch request fetcher

Project Member Reported by jianli@chromium.org, May 1 2017

Issue description

Implement offline prefetch request fetcher

 
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874c38a6ffddc2794f18a913297cd1cdfbae3526

commit 874c38a6ffddc2794f18a913297cd1cdfbae3526
Author: jianli <jianli@chromium.org>
Date: Fri May 12 20:00:08 2017

[Offline Prefetch] Send GeneratePageBundleRequest to the server

BUG= 717305 
TEST=new tests

Review-Url: https://codereview.chromium.org/2873383004
Cr-Commit-Position: refs/heads/master@{#471420}

[modify] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/BUILD.gn
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/generate_page_bundle_request.h
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc
[modify] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
[modify] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_request_fetcher.h
[modify] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_request_test_base.cc
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_request_test_base.h
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_types.cc
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_types.h
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_utils.cc
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/prefetch_utils.h
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/proto/any.proto
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/proto/offline_pages.proto
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/proto/operation.proto
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/proto/status.proto
[add] https://crrev.com/874c38a6ffddc2794f18a913297cd1cdfbae3526/components/offline_pages/core/prefetch/proto/timestamp.proto

Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84

commit fe5a1735a59cd3c01e338b89d9b12bd052ac0d84
Author: jianli <jianli@chromium.org>
Date: Thu May 18 22:41:30 2017

[Offline Prefetech] Send GetOperationRequest to the server

BUG= 717305 
TEST=new tests

Review-Url: https://codereview.chromium.org/2889453003
Cr-Commit-Position: refs/heads/master@{#472956}

[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/BUILD.gn
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/generate_page_bundle_request.h
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc
[add] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/get_operation_request.cc
[add] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/get_operation_request.h
[add] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
[rename] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_proto_utils.cc
[add] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_proto_utils.h
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_request_fetcher.h
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc
[add] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_request_test_base.cc
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_request_test_base.h
[modify] https://crrev.com/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84/components/offline_pages/core/prefetch/prefetch_types.h
[delete] https://crrev.com/2bb48c8a1af8c61799d7a1e3031d956deb61730b/components/offline_pages/core/prefetch/prefetch_utils.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4aab113db5e8150b07424daffab59a42d82f917

commit a4aab113db5e8150b07424daffab59a42d82f917
Author: jianli <jianli@chromium.org>
Date: Tue Jun 06 20:36:59 2017

[Offline Prefetch] Pass api key to offline prefetch requests

BUG= 717305 
TEST=tests updated

Review-Url: https://codereview.chromium.org/2921783002
Cr-Commit-Position: refs/heads/master@{#477393}

[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/BUILD.gn
[add] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/DEPS
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/generate_page_bundle_request.h
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/get_operation_request.cc
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/get_operation_request.h
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/prefetch_request_fetcher.h
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc
[modify] https://crrev.com/a4aab113db5e8150b07424daffab59a42d82f917/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd608208e501cb0572d4466e3e372c02b64c564c

commit bd608208e501cb0572d4466e3e372c02b64c564c
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Jun 14 22:01:55 2017

[Offline Pages] Fix bug in GetOperationRequest URL handling.

Because operation names include "operations/" in the string, we do not
want to also append it while constructing the GetOperationRequest.

Bug:  717305 
Change-Id: I8a46e756a6073c81a694ea354c145b55abc3d51b
Reviewed-on: https://chromium-review.googlesource.com/535227
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479519}
[modify] https://crrev.com/bd608208e501cb0572d4466e3e372c02b64c564c/components/offline_pages/core/prefetch/get_operation_request_unittest.cc

Comment 6 by jianli@chromium.org, Jul 18 2017

Status: Fixed (was: Started)

Sign in to add a comment